Implement core type validation tests, part 1.

Author: jhgg

graphql/core/type/definition.py

@@ -237,7 +237,7 @@ def define_field_map(type, field_map):
             for arg_name, arg in field_args.items():
                 assert_valid_name(arg_name)
                 assert isinstance(arg, GraphQLArgument), (
-                    '{}.{}({}:) argument must be an instance of GraphQLArgument'.format(type, field_name, arg_name)
+                    '{}.{}({}:) argument must be an instance of GraphQLArgument.'.format(type, field_name, arg_name)
                 )
                 assert is_input_type(arg.type), (
                     '{}.{}({}:) argument type must be Input Type but got: {}.'.format(type, field_name, arg_name,

tests/core_starwars/__init__.py

@@ -5,40 +5,40 @@
 luke = Human(
     id='1000',
     name='Luke Skywalker',
-    friends=[ '1002', '1003', '2000', '2001' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1002', '1003', '2000', '2001'],
+    appearsIn=[4, 5, 6],
     homePlanet='Tatooine',
 )
 
 vader = Human(
     id='1001',
     name='Darth Vader',
-    friends=[ '1004' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1004'],
+    appearsIn=[4, 5, 6],
     homePlanet='Tatooine',
 )
 
 han = Human(
     id='1002',
     name='Han Solo',
-    friends=[ '1000', '1003', '2001' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1000', '1003', '2001'],
+    appearsIn=[4, 5, 6],
     homePlanet=None,
 )
 
 leia = Human(
     id='1003',
     name='Leia Organa',
-    friends=[ '1000', '1002', '2000', '2001' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1000', '1002', '2000', '2001'],
+    appearsIn=[4, 5, 6],
     homePlanet='Alderaan',
 )
 
 tarkin = Human(
     id='1004',
     name='Wilhuff Tarkin',
-    friends=[ '1001' ],
-    appearsIn=[ 4 ],
+    friends=['1001'],
+    appearsIn=[4],
     homePlanet=None,
 )
 
@@ -55,16 +55,16 @@
 threepio = Droid(
     id='2000',
     name='C-3PO',
-    friends=[ '1000', '1002', '1003', '2001' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1000', '1002', '1003', '2001'],
+    appearsIn=[4, 5, 6],
     primaryFunction='Protocol',
 )
 
 artoo = Droid(
     id='2001',
     name='R2-D2',
-    friends=[ '1000', '1002', '1003' ],
-    appearsIn=[ 4, 5, 6 ],
+    friends=['1000', '1002', '1003'],
+    appearsIn=[4, 5, 6],
     primaryFunction='Astromech',
 )
 
@@ -73,6 +73,7 @@
     '2001': artoo,
 }
 
+
 def getCharacter(id):
     return humanData.get(id) or droidData.get(id)
 

tests/core_starwars/starwars_fixtures.py

@@ -10,7 +10,7 @@
     GraphQLSchema,
     GraphQLString,
 )
-import starwars_fixtures
+from .starwars_fixtures import getHero, getHuman, getFriends, getDroid
 
 episodeEnum = GraphQLEnumType(
     'Episode',
@@ -52,7 +52,7 @@
             description='Which movies they appear in.'
         ),
     },
-    resolve_type=lambda character, *_: humanType if starwars_fixtures.getHuman(character.id) else droidType,
+    resolve_type=lambda character, *_: humanType if getHuman(character.id) else droidType,
 )
 
 humanType = GraphQLObjectType(
@@ -70,7 +70,7 @@
         'friends': GraphQLField(
             GraphQLList(characterInterface),
             description='The friends of the human, or an empty list if they have none.',
-            resolver=lambda human, *_: starwars_fixtures.getFriends(human),
+            resolver=lambda human, *_: getFriends(human),
         ),
         'appearsIn': GraphQLField(
             GraphQLList(episodeEnum),
@@ -99,7 +99,7 @@
         'friends': GraphQLField(
             GraphQLList(characterInterface),
             description='The friends of the droid, or an empty list if they have none.',
-            resolver=lambda droid, *_: starwars_fixtures.getFriends(droid),
+            resolver=lambda droid, *_: getFriends(droid),
         ),
         'appearsIn': GraphQLField(
             GraphQLList(episodeEnum),
@@ -125,7 +125,7 @@
                     type=episodeEnum,
                 )
             },
-            resolver=lambda root, args, *_: starwars_fixtures.getHero(args.get('episode')),
+            resolver=lambda root, args, *_: getHero(args.get('episode')),
         ),
         'human': GraphQLField(
             humanType,
@@ -135,7 +135,7 @@
                     type=GraphQLNonNull(GraphQLString),
                 )
             },
-            resolver=lambda root, args, *_: starwars_fixtures.getHuman(args['id']),
+            resolver=lambda root, args, *_: getHuman(args['id']),
         ),
         'droid': GraphQLField(
             droidType,
@@ -145,7 +145,7 @@
                     type=GraphQLNonNull(GraphQLString),
                 )
             },
-            resolver=lambda root, args, *_: starwars_fixtures.getDroid(args['id']),
+            resolver=lambda root, args, *_: getDroid(args['id']),
         ),
     }
 )

tests/core_starwars/starwars_schema.py

@@ -1,4 +1,4 @@
-from starwars_schema import StarWarsSchema
+from .starwars_schema import StarWarsSchema
 from graphql.core import graphql
 from graphql.core.error import format_error
 

tests/core_starwars/test_query.py

@@ -1,7 +1,7 @@
 from graphql.core.language.source import Source
 from graphql.core.language.parser import parse
 from graphql.core.validation import validate
-from starwars_schema import StarWarsSchema
+from .starwars_schema import StarWarsSchema
 
 
 def validation_errors(query):