Use __slots__ in even more places.

Author: jhgg

graphql/core/error.py

@@ -6,6 +6,8 @@ class Error(Exception):
 
 
 class GraphQLError(Error):
+    __slots__ = 'message', 'nodes', 'stack', '_source', '_positions'
+
     def __init__(self, message, nodes=None, stack=None, source=None, positions=None):
         super(GraphQLError, self).__init__(message)
         self.message = message
@@ -43,5 +45,5 @@ def format_error(error):
         'locations': [
             {'line': loc.line, 'column': loc.column}
             for loc in error.locations
-        ],
+            ],
     }

graphql/core/execution/base.py

@@ -27,6 +27,8 @@ class ExecutionContext(object):
     Namely, schema of the type system that is currently executing,
     and the fragments defined in the query document"""
 
+    __slots__ = 'schema', 'fragments', 'root', 'operation', 'variables', 'errors', 'request_context'
+
     def __init__(self, schema, root, document_ast, operation_name, args, request_context):
         """Constructs a ExecutionContext object from the arguments passed
         to execute, which we will pass throughout the other execution
@@ -75,13 +77,15 @@ class ExecutionResult(object):
     query, `errors` is null if no errors occurred, and is a
     non-empty array if an error occurred."""
 
+    __slots__ = 'data', 'errors', 'invalid'
+
     def __init__(self, data=None, errors=None, invalid=False):
         self.data = data
         if errors:
             errors = [
                 error.value if isinstance(error, DeferredException) else error
                 for error in errors
-            ]
+                ]
 
         self.errors = errors
 

graphql/core/language/ast.py

@@ -3,11 +3,11 @@
 
 
 class Node(object):
-    pass
+    __slots__ = ()
 
 
 class Definition(Node):
-    pass
+    __slots__ = ()
 
 
 class Document(Node):
@@ -163,7 +163,7 @@ def __hash__(self):
 
 
 class Selection(Node):
-    pass
+    __slots__ = ()
 
 
 class Field(Selection):
@@ -371,7 +371,7 @@ def __hash__(self):
 
 
 class Value(Node):
-    pass
+    __slots__ = ()
 
 
 class Variable(Value):
@@ -703,7 +703,7 @@ def __hash__(self):
 
 
 class Type(Node):
-    pass
+    __slots__ = ()
 
 
 class NamedType(Type):
@@ -835,7 +835,7 @@ def __hash__(self):
 
 
 class TypeDefinition(Node):
-    pass
+    __slots__ = ()
 
 
 class ObjectTypeDefinition(TypeDefinition):

graphql/core/language/printer.py

@@ -9,6 +9,8 @@ def print_ast(ast):
 
 
 class PrintingVisitor(Visitor):
+    __slots__ = ()
+
     def leave_Name(self, node, *args):
         return node.value
 

graphql/core/language/source.py

@@ -2,6 +2,8 @@
 
 
 class Source(object):
+    __slots__ = 'body', 'name'
+
     def __init__(self, body, name='GraphQL'):
         self.body = body
         self.name = name

graphql/core/pyutils/default_ordered_dict.py

@@ -2,6 +2,8 @@
 
 
 class DefaultOrderedDict(OrderedDict):
+    __slots__ = 'default_factory',
+
     # Source: http://stackoverflow.com/a/6190500/562769
     def __init__(self, default_factory=None, *a, **kw):
         if (default_factory is not None and

graphql/core/pyutils/defer.py

@@ -73,6 +73,7 @@ class AlreadyCalledDeferred(Exception):
 
 class DeferredException(object):
     """Allows to defer exceptions."""
+    __slots__ = 'type', 'value', 'traceback'
 
     def __init__(self, type=None, value=None, traceback=None):
         """Return a new DeferredException instance.
@@ -190,6 +191,8 @@ class Deferred(object):
         CALLBACK3      ERRBACK3
       """
 
+    __slots__ = 'callbacks', 'errbacks', 'called', 'paused', '_running', 'result'
+
     def __init__(self):
         """Return a new Deferred instance."""
         self.callbacks = []

graphql/core/pyutils/pair_set.py

@@ -1,4 +1,6 @@
 class PairSet(object):
+    __slots__ = '_data',
+
     def __init__(self):
         self._data = set()
 

scripts/generate_ast.py

@@ -36,7 +36,7 @@ def start_file(self):
 
 
 class Node(object):
-    pass''')
+    __slots__ = ()''')
 
     def end_file(self):
         pass
@@ -131,7 +131,7 @@ def start_union(self, name):
         print('''
 
 class {name}(Node):
-    pass'''.format(name=name))
+    __slots__ = ()'''.format(name=name))
 
     def union_option(self, option):
         option = remap_type(option)