refactor: resolve methods can throw Errors. They cannot populate error fields because they don't know anything about it. So decision about errors (return error in mutation payload or return it in top-level) can be made only in resolver wrapper addErrorCatcherField.

Author: nodkz

src/resolvers/createMany.ts

@@ -8,7 +8,6 @@ import {
   validationsForDocument,
   ValidationsWithMessage,
   ManyValidations,
-  ManyValidationsWithMessage,
 } from '../errors/validationsForDocument';
 
 export default function createMany<TSource = Document, TContext = any>(
@@ -51,6 +50,7 @@ export default function createMany<TSource = Document, TContext = any>(
       createCount: {
         type: 'Int!',
         description: 'Number of created documents',
+        resolve: (s: any) => s.createCount || 0,
       },
     });
   });
@@ -106,36 +106,20 @@ export default function createMany<TSource = Document, TContext = any>(
       }
 
       const hasValidationError = !manyValidations.every((error) => error === null);
-      if (!hasValidationError) {
-        await model.create(docs);
-      }
-
       if (hasValidationError) {
-        const manyValidationsWithMessage: ManyValidationsWithMessage = {
-          message: 'Cannot createMany some documents contain errors',
+        throw new ManyValidationError({
+          message: 'Cannot execute createMany, some documents contain errors',
           errors: manyValidations,
-        };
-
-        if (!resolveParams?.projection?.error) {
-          // if client does not request `errors` field we throw Exception on to level
-          throw new ManyValidationError(manyValidationsWithMessage);
-        }
-        return {
-          records: null,
-          recordIds: null,
-          error: {
-            name: 'ManyValidationError',
-            ...manyValidationsWithMessage,
-          },
-          createCount: 0,
-        };
-      } else {
-        return {
-          records: docs,
-          recordIds: docs.map((doc) => doc._id),
-          createCount: docs.length,
-        };
+        });
       }
+
+      await model.create(docs);
+
+      return {
+        records: docs,
+        recordIds: docs.map((doc) => doc._id),
+        createCount: docs.length,
+      };
     },
   });
 

src/resolvers/createOne.ts

@@ -77,26 +77,8 @@ export default function createOne<TSource = Document, TContext = any>(
       }
 
       const validations: ValidationsWithMessage | null = await validationsForDocument(doc);
-
       if (validations) {
-        if (!resolveParams?.projection?.error) {
-          // if client does not request `errors` field we throw Exception on to level
-          throw new ValidationError(validations);
-        }
-        return {
-          record: null,
-          recordId: null,
-          error: {
-            name: 'ValidationError',
-            ...validations,
-          },
-        };
-      } else {
-        await doc.save();
-        return {
-          record: doc,
-          recordId: tc.getRecordIdFn()(doc as any),
-        };
+        throw new ValidationError(validations);
       }
 
       await doc.save();

src/resolvers/updateById.ts

@@ -88,25 +88,27 @@ export default function updateById<TSource = Document, TContext = any>(
         throw new Error('Document not found');
       }
 
-      if (recordData) {
-        doc.set(recordData);
-
-        const validationErrors = await new Promise((resolve) => {
-          doc.validate(null, null, resolve);
-        });
-        if (validationErrors) {
-          throw new ValidationError(validationErrors as any);
-        }
-
-        await doc.save();
-
-        return {
-          record: doc,
-          recordId: tc.getRecordIdFn()(doc),
-        };
+      if (!recordData) {
+        throw new Error(
+          `${tc.getTypeName()}.updateById resolver doesn't receive new data in args.record`
+        );
       }
 
-      return null;
+      doc.set(recordData);
+
+      const validationErrors = await new Promise((resolve) => {
+        doc.validate(null, null, resolve);
+      });
+      if (validationErrors) {
+        throw new ValidationError(validationErrors as any);
+      }
+
+      await doc.save();
+
+      return {
+        record: doc,
+        recordId: tc.getRecordIdFn()(doc),
+      };
     }) as any,
   });
 

src/resolvers/updateOne.ts

@@ -34,10 +34,6 @@ export default function updateOne<TSource = Document, TContext = any>(
         type: tc,
         description: 'Updated document',
       },
-      errors: {
-        type: '[ErrorInterface]',
-        description: 'Errors that may occur',
-      },
     });
   });
 
@@ -92,43 +88,23 @@ export default function updateOne<TSource = Document, TContext = any>(
         doc = await resolveParams.beforeRecordMutate(doc, resolveParams);
       }
 
+      if (!doc) return null;
+
       if (recordData) {
         doc.set(recordData);
 
         const validations: ValidationsWithMessage | null = await validationsForDocument(doc);
-
         if (validations) {
-          if (!resolveParams?.projection?.error) {
-            // if client does not request `errors` field we throw Exception on to level
-            throw new ValidationError(validations);
-          }
-          return {
-            record: null,
-            recordId: null,
-            error: {
-              name: 'ValidationError',
-              ...validations,
-            },
-          };
-        } else {
-          await doc.save();
-          return {
-            record: doc,
-            recordId: tc.getRecordIdFn()(doc as any),
-          };
+          throw new ValidationError(validations);
         }
 
         await doc.save();
       }
 
-      if (doc) {
-        return {
-          record: doc,
-          recordId: tc.getRecordIdFn()(doc as any),
-        };
-      }
-
-      return null;
+      return {
+        record: doc,
+        recordId: tc.getRecordIdFn()(doc as any),
+      };
     }) as any,
   });