Release 1.1.0 (#129)

Author: Craig Gower-Page

.markdownlintignore

@@ -0,0 +1,2 @@
+
+cran-comments.md

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: diffdf
 Type: Package
 Title: Dataframe Difference Tool
-Version: 1.0.4.900
+Version: 1.1.0
 Authors@R: c( 
     person("Craig" ,"Gower-Page" , email = "craig.gower-page@roche.com" , role = c("cre","aut")),
     person("Kieran", "Martin" , email = "kieran.martin@roche.com" , role = "aut")
@@ -11,7 +11,6 @@ Description: Functions for comparing two data.frames against
     between two data.frames as well as providing utility functions to help narrow down the 
     source of problems and differences.
 Encoding: UTF-8
-LazyData: true
 Language: en-GB
 Depends:
     R (>= 3.1.2)

NEWS.md

@@ -1,16 +1,19 @@
-# diffdf 1.0.4.900
+# diffdf 1.1.0
 
-Development version
+## New features
 
-- Enhanced table printing so that white space characters are more clearly defined (#87)
-- `row_limit` argument now functional again in print method! (#6, @brianrepko)
-- Fixed bug that caused an error if either the base or comparison dataset were empty (#44)
-- Fixed bug that caused an error if there were no matching keys between the base and comparison dataset (#79)
+- Enhanced table printing so that white space characters are more clearly displayed (#87)
+- Added `row_limit` argument to print method to limit the number of rows displayed (#6, @brianrepko)
 - Added check to ensure that the column ordering is the same (#32)
-- Added more informative error messaging if a specified key is missing from the base or comparison dataset (#113)
 - Added check for differences in classes between the base and comparison datasets (#42)
 - Updated character formatting of datetimes to show time zone to avoid misleading/confusing comparisons (#121)
 
+## Minor improvements and fixes
+
+- Added more informative error messaging if a specified key is missing from the base or comparison dataset (#113)
+- Fixed bug that caused an error if either the base or comparison dataset were empty (#44)
+- Fixed bug that caused an error if there were no matching keys between the base and comparison dataset (#79)
+
 
 # diffdf 1.0.4
 

R/is_different.R

@@ -139,12 +139,15 @@ compare_vectors.factor <- function(target, current, ...) {
 #' @param current a vector to compare target to
 #' @param tolerance Level of tolerance for differences between two variables
 #' @param scale Scale that tolerance should be set on. If NULL assume absolute
+#' @param ... Not used
 #' @keywords internal
 compare_vectors.numeric <- function(
-        target,
-        current,
-        tolerance = sqrt(.Machine$double.eps),
-        scale = NULL) {
+    target,
+    current,
+    tolerance = sqrt(.Machine$double.eps),
+    scale = NULL,
+    ...
+) {
 
     out <- target == current
 
@@ -173,11 +176,14 @@ compare_vectors.numeric <- function(
 #' @param current a vector to compare target to
 #' @param tolerance Level of tolerance for differences between two variables
 #' @param scale Scale that tolerance should be set on. If NULL assume absolute
+#' @param ... Not used
 #' @keywords internal
 compare_vectors.integer64 <- function(
-        target,
-        current,
-        tolerance = sqrt(.Machine$double.eps),
-        scale = NULL) {
+    target,
+    current,
+    tolerance = sqrt(.Machine$double.eps),
+    scale = NULL,
+    ...
+) {
     compare_vectors.numeric(target, current, tolerance, scale)
 }

R/issues.R

@@ -46,8 +46,9 @@ get_print_message <- function(object, ...) {
 #'
 #' Errors, as this should only ever be given an issue
 #' @param object issue
+#' @param ... Not used
 #' @keywords internal
-get_print_message.default <- function(object) {
+get_print_message.default <- function(object, ...) {
     stop("Error: An issue has not been provided to this function!")
 }
 

README.md

@@ -7,21 +7,33 @@
 [![Code Coverage 📔](https://raw.githubusercontent.com/gowerc/diffdf/_xml_coverage_reports/data/master/badge.svg)](https://gowerc.github.io/diffdf/master/coverage-report/)
 <!-- end badges -->
 
-The diffdf package is designed to enable detailed comparison of two data.frames. Whilst many packages exist for informing you if there are differences between data.frames, none provide as much detail on what and where those differences are as diffdf does!
+`diffdf` compares two `data.frame` objects and provides a detailed summary of any differences that were found between them. The package has it's origins in supporting QC workflows for product development within the pharmaceutical industry aiming at being a light weight alternative to SAS's `PROC COMPARE`.
 
 Currently diffdf supports the following:
 
-- Checking for differences in values
-- Checking for differences in attributes
-- Checking for differences in classes
-- Checking for differences in column names
-- Checking for differences in the number of observations
+- Checking for differences in:
+  - Values
+  - Attributes
+  - Classes
+  - Column names
+  - Number of observations
+  - Column ordering
 - Matching rows by key/id variables
 - Fuzzy comparisons (i.e. treating doubles and integers as the same)
 - Extracting datasets of different rows
 
 For more information on features please consult the vignette and man pages.
 
+## Alternatives
+
+If `diffdf` isn't quite right for your use case then the following are other packages that provide similar functionality that may be more appropriate:
+
+- [`daff`](https://CRAN.R-project.org/package=daff)
+- [`compareDF`](https://CRAN.R-project.org/package=compareDF)
+- [`waldo`](https://CRAN.R-project.org/package=waldo)
+- [`diffobj`](https://CRAN.R-project.org/package=diffobj)
+- [`arsenal`](https://CRAN.R-project.org/package=arsenal)
+
 ## Installation
 
 You can install the released version of diffdf from [CRAN](https://CRAN.R-project.org/package=diffdf) with:

cran-comments.md

@@ -1,16 +1,16 @@
-## Release summary
-In this version I have:
-- Updated the package to fix errors introduced by the most recent version of tibble (2.99.99.9014 which will become 3.0.0 upon release) 
-- Updated my email in the maintainers list from craig.gower@roche.com to craig.gower-page@roche.com as I have changed my name after getting married and work updated my email address. I no longer have access or the ability to send emails from the old email address however emails to the old email address are forwarded to the new one (that is if you wish to confirm this change). 
-
-## Test environments
-- local Mac OS Mojave R 3.6.2
-- Windows Server 2008 R2 SP1, R-devel, 32/64 bit (Rhub)
-- Debian Linux, R-release, GCC (Rhub)
-
 ## R CMD check results
+
 R CMD check results
-0 errors | 0 warnings | 0 notes
+0 errors ✔ | 0 warnings ✔ | 0 notes ✔
+
+## revdepcheck results
+
+We checked the following reverse dependencies, all passed with no issues:
 
-## Downstream dependencies
-There are currently no downstream dependencies for this package
+- admiral
+- admiraldev
+- admiralonco
+- admiralophtha
+- admiralvaccine
+- pharmaverseadam
+- random.cdisc.data

inst/WORDLIST

@@ -7,3 +7,8 @@ int64
 int
 datetimes
 datetime
+SAS's
+compareDF
+daff
+diffobj
+waldo