Merge pull request #23 from goude/claude/fix-broken-image-tests-Li0PW

Replace external image URLs with local assets

Author: goude

public/placeholder.svg

@@ -0,0 +1,40 @@
+import { describe, it, expect } from "vitest";
+import fs from "node:fs";
+import path from "node:path";
+
+const SRC_DIR = path.resolve(import.meta.dirname, "../src");
+
+/** Recursively collect all files matching an extension under dir. */
+function collectFiles(dir, ext) {
+  const results = [];
+  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
+    const full = path.join(dir, entry.name);
+    if (entry.isDirectory()) {
+      results.push(...collectFiles(full, ext));
+    } else if (entry.isFile() && entry.name.endsWith(ext)) {
+      results.push(full);
+    }
+  }
+  return results;
+}
+
+/** Match <img ...src="https://..."> across tag boundaries (multiline). */
+const IMG_EXTERNAL_SRC = /<img\b[^>]*\bsrc=["']https?:\/\/[^"']+["'][^>]*>/gis;
+
+describe("external image references in source files", () => {
+  it("no .astro file uses an external http(s) URL as <img src>", () => {
+    const astroFiles = collectFiles(SRC_DIR, ".astro");
+    const violations = [];
+
+    for (const file of astroFiles) {
+      const content = fs.readFileSync(file, "utf8");
+      const matches = [...content.matchAll(IMG_EXTERNAL_SRC)];
+      for (const m of matches) {
+        const lineNumber = content.slice(0, m.index).split("\n").length;
+        violations.push(`${path.relative(SRC_DIR, file)}:${lineNumber}: ${m[0].slice(0, 80)}…`);
+      }
+    }
+
+    expect(violations, `External <img src> URLs found:\n${violations.join("\n")}`).toEqual([]);
+  });
+});

scripts/check-external-images.test.mjs

@@ -147,9 +147,9 @@ import Layout from "@/layouts/Layout.astro";
 
       <figure>
         <picture>
-          <source srcset="https://via.placeholder.com/400x200" />
+          <source srcset="/placeholder.svg" />
           <img
-            src="https://via.placeholder.com/400x200"
+            src="/placeholder.svg"
             alt="Placeholder"
             width="400"
             height="200"

src/pages/ai-generated/markup.astro

@@ -22,7 +22,7 @@
 
   <figure class="article-figure">
     <img
-      src="https://upload.wikimedia.org/wikipedia/commons/thumb/e/e2/Gold_Star_Studios.jpg/1024px-Gold_Star_Studios.jpg"
+      src="/ai-generated/wall-of-sound/gold-star-studios.jpg"
       alt="The exterior of Gold Star Studios on Santa Monica Boulevard, Los Angeles"
       loading="lazy"
       decoding="async"