From 90e9009c413fff9b397173a8af7453fe679bde0e Mon Sep 17 00:00:00 2001 From: William French Date: Wed, 17 Jun 2026 10:02:47 -0700 Subject: [PATCH 1/2] test: ensure nightly scheduled tests run all samples unconditionally --- .github/workflows/tests.yml | 1 + e2e/samples.spec.ts | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 57752aa68..a24330205 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -216,6 +216,7 @@ jobs: run: npx playwright test e2e/samples.spec.ts env: CI: true + TEST_ALL_SAMPLES: "true" - name: Upload Test Report Artifact uses: actions/upload-artifact@v4 diff --git a/e2e/samples.spec.ts b/e2e/samples.spec.ts index bd5493604..f4a4d5f11 100644 --- a/e2e/samples.spec.ts +++ b/e2e/samples.spec.ts @@ -42,6 +42,13 @@ const getChangedSampleFolders = (): string[] => { 'find-changes.sh' ); + if (process.env.TEST_ALL_SAMPLES === 'true') { + console.log( + 'TEST_ALL_SAMPLES is set. Running tests for all samples.' + ); + return getAllSampleFolders(); + } + if (!fs.existsSync(scriptPath)) { console.warn( `Warning: find-changes.sh not found at ${scriptPath}. Running tests for all samples.` From 79c0e3ffd404c996984802b5873342d21b153ef2 Mon Sep 17 00:00:00 2001 From: William French Date: Thu, 18 Jun 2026 09:38:15 -0700 Subject: [PATCH 2/2] Remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 variable Removed FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable. The 3P actions plugins in use here all depend on Node 20, so this is not needed. In general the internal runner node can use a different version of Node (even though Node 20 is slated for deprecation in September of 2026). --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a24330205..7f6855980 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -34,7 +34,6 @@ on: - cron: "0 12 * * *" env: - FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true SKIP_DIST: ${{ github.event_name == 'pull_request' || github.event_name == 'schedule' }} concurrency: