Skip to content

Commit e1e038d

Browse files
check table nullity properly
1 parent aa519e6 commit e1e038d

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

bigframes/core/compile/compiled.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -166,18 +166,6 @@ def get_column_type(self, key: str) -> bigframes.dtypes.Dtype:
166166
bigframes.core.compile.ibis_types.ibis_dtype_to_bigframes_dtype(ibis_type),
167167
)
168168

169-
def row_count(self, name: str) -> UnorderedIR:
170-
original_table = self._to_ibis_expr()
171-
ibis_table = original_table.agg(
172-
[
173-
original_table.count().name(name),
174-
]
175-
)
176-
return UnorderedIR(
177-
ibis_table,
178-
(ibis_table[name],),
179-
)
180-
181169
def _to_ibis_expr(
182170
self,
183171
*,

bigframes/core/compile/ibis_compiler/utils.py

Whitespace-only changes.

third_party/bigframes_vendored/ibis/expr/types/generic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ def over(
774774
@deferrable
775775
def bind(table):
776776
winfunc = rewrite_window_input(
777-
node, window.bind(table) if table else window
777+
node, window.bind(table) if (table is not None) else window
778778
)
779779
if winfunc == node:
780780
raise com.IbisTypeError(
@@ -784,7 +784,7 @@ def bind(table):
784784

785785
try:
786786
return bind(table)
787-
except com.IbisInputError as e:
787+
except com.IbisInputError:
788788
return bind(_)
789789

790790
def isnull(self) -> ir.BooleanValue:

0 commit comments

Comments
 (0)