Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit 800aff9

Browse files
committed
fix mypy
1 parent 8bdbcb2 commit 800aff9

1 file changed

Lines changed: 33 additions & 5 deletions

File tree

bigframes/session/_io/bigquery/__init__.py

Lines changed: 33 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ def start_query_with_client(
249249
timeout: Optional[float],
250250
metrics: Optional[bigframes.session.metrics.ExecutionMetrics],
251251
query_with_job: Literal[True],
252-
job_retry: Optional[google.api_core.retry.Retry],
253252
) -> Tuple[bigquery.table.RowIterator, bigquery.QueryJob]:
254253
...
255254

@@ -265,7 +264,38 @@ def start_query_with_client(
265264
timeout: Optional[float],
266265
metrics: Optional[bigframes.session.metrics.ExecutionMetrics],
267266
query_with_job: Literal[False],
268-
job_retry: Optional[google.api_core.retry.Retry],
267+
) -> Tuple[bigquery.table.RowIterator, Optional[bigquery.QueryJob]]:
268+
...
269+
270+
271+
@overload
272+
def start_query_with_client(
273+
bq_client: bigquery.Client,
274+
sql: str,
275+
*,
276+
job_config: bigquery.QueryJobConfig,
277+
location: Optional[str],
278+
project: Optional[str],
279+
timeout: Optional[float],
280+
metrics: Optional[bigframes.session.metrics.ExecutionMetrics],
281+
query_with_job: Literal[True],
282+
job_retry: google.api_core.retry.Retry,
283+
) -> Tuple[bigquery.table.RowIterator, bigquery.QueryJob]:
284+
...
285+
286+
287+
@overload
288+
def start_query_with_client(
289+
bq_client: bigquery.Client,
290+
sql: str,
291+
*,
292+
job_config: bigquery.QueryJobConfig,
293+
location: Optional[str],
294+
project: Optional[str],
295+
timeout: Optional[float],
296+
metrics: Optional[bigframes.session.metrics.ExecutionMetrics],
297+
query_with_job: Literal[False],
298+
job_retry: google.api_core.retry.Retry,
269299
) -> Tuple[bigquery.table.RowIterator, Optional[bigquery.QueryJob]]:
270300
...
271301

@@ -284,9 +314,7 @@ def start_query_with_client(
284314
# google-cloud-bigquery version with
285315
# https://github.com/googleapis/python-bigquery/pull/2256 merged, likely
286316
# version 3.36.0 or later.
287-
job_retry: Optional[
288-
google.api_core.retry.Retry
289-
] = third_party_gcb_retry.DEFAULT_JOB_RETRY,
317+
job_retry: google.api_core.retry.Retry = third_party_gcb_retry.DEFAULT_JOB_RETRY,
290318
) -> Tuple[bigquery.table.RowIterator, Optional[bigquery.QueryJob]]:
291319
"""
292320
Starts query job and waits for results.

0 commit comments

Comments
 (0)