Skip to content

Commit b49caaf

Browse files
committed
feat(spanner): fix asyncio event loop leak in unit tests and activate type check
1 parent 5accbb4 commit b49caaf

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

packages/google-cloud-spanner/noxfile.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -753,8 +753,6 @@ def prerelease_deps(session, protobuf_implementation, database_dialect):
753753
@nox.session(python=ALL_PYTHON)
754754
def mypy(session):
755755
"""Run the type checker."""
756-
session.skip("Mypy is not yet supported")
757-
758756
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2579):
759757
# use the latest version of mypy
760758
session.install(

packages/google-cloud-spanner/tests/unit/gapic/conftest.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@ def provide_loop_to_sync_grpc_tests():
1111
If no global loop exists, `grpc.aio` engine crashes during initialization.
1212
"""
1313
try:
14-
loop = asyncio.get_event_loop()
14+
asyncio.get_running_loop()
15+
yield
1516
except RuntimeError:
1617
loop = asyncio.new_event_loop()
1718
asyncio.set_event_loop(loop)
18-
19-
yield
20-
# No close here, just ensure existance
19+
try:
20+
yield
21+
finally:
22+
loop.close()
23+
asyncio.set_event_loop(None)

0 commit comments

Comments
 (0)