Skip to content

chore(.github/workflows): let librarian update workflow also sync new commit to generation_config.yaml #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhumin8 merged 4 commits into from
Jun 5, 2026
Merged

chore(.github/workflows): let librarian update workflow also sync new commit to generation_config.yaml #13372

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fedf74a
chore(.github/workflows): let librarian update workflow also sync new…
zhumin8 Jun 5, 2026
c164afc
add comment to remove this step once ready to remove hermetic build w…
zhumin8 Jun 5, 2026
b6856dd
revert unnecessary changes
zhumin8 Jun 5, 2026
9ae0717
update log print for Update generation_config.yaml step
zhumin8 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/update_librarian_googleapis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ jobs:
new_commit=$(go run "github.com/googleapis/librarian/cmd/librarian@${version}" config get sources.googleapis.commit)
echo "new_commit=${new_commit}" >> $GITHUB_OUTPUT
echo "short_commit=${new_commit:0:7}" >> $GITHUB_OUTPUT
# TODO(https://github.com/googleapis/librarian/issues/6220): Remove this step.
- name: Update generation_config.yaml
run: |
sed -i -e "s/^googleapis_commitish.*$/googleapis_commitish: ${{ steps.commit.outputs.new_commit }}/" generation_config.yaml
git diff generation_config.yaml
- name: Detect Changes To Librarian.yaml
id: detect_librarian
run: |
Expand Down Expand Up @@ -127,7 +132,7 @@ jobs:
env:
GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_GITHUB_TOKEN }}
PR_TITLE: "chore: update googleapis commitish to ${{ steps.commit.outputs.short_commit }}"
PR_BODY: "Updated googleapis commitish in librarian.yaml to https://github.com/googleapis/googleapis/commit/${{ steps.commit.outputs.new_commit }}"
PR_BODY: "Updated googleapis commitish in librarian.yaml and generation_config.yaml to https://github.com/googleapis/googleapis/commit/${{ steps.commit.outputs.new_commit }}"
run: |
set -x

Expand Down
Loading