Skip to content

chore(.github/workflows): let librarian update workflow also sync new commit to generation_config.yaml#13372

Merged
zhumin8 merged 4 commits into
googleapis:mainfrom
zhumin8:librarian-workflow-update-generation-config
Jun 5, 2026
Merged

chore(.github/workflows): let librarian update workflow also sync new commit to generation_config.yaml#13372
zhumin8 merged 4 commits into
googleapis:mainfrom
zhumin8:librarian-workflow-update-generation-config

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Add this step temporarily so that this workflow also triggers hermetic build generation workflow, and we can verify changes in the same PR.
This change is intended to be set till 06/10/2026 to verify librarian generate against hermetic build.

Here is the sequence:

  • nightly, this scheduled workflow updates librarian.yaml with new googleapis commit.
  • [additional step] update generation_config.yaml with same commit.
  • run librarian generate -all and add code change to commit
  • raise PR.
  • hermetic build generation workflow triggered because generation_config.yaml googleapis_commitish is updated.

On the next day, we verify the results on this PR, expect hermetic build [generation workflow] runs succesfully with no code change added. If any, we should investigate the diff.

Note: hermetic build workflow will not trigger on this PR, because I pushed from fork. This is to avoid it adding code changes to this PR.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@zhumin8 zhumin8 marked this pull request as ready for review June 5, 2026 13:29
@zhumin8 zhumin8 requested review from a team as code owners June 5, 2026 13:29
@zhumin8 zhumin8 requested review from JoeWang1127 and sofisl June 5, 2026 13:41
@zhumin8

zhumin8 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

dry run updates commit as expected: https://screenshot.googleplex.com/4JrQaWBWzaMKCLh

@zhumin8 zhumin8 enabled auto-merge (squash) June 5, 2026 14:00
@zhumin8 zhumin8 merged commit 5f977fc into googleapis:main Jun 5, 2026
178 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants