Skip to content

feat(storage): enable App-Centric Observability (ACO) support in Otel#13248

Open
nidhiii-27 wants to merge 5 commits into
mainfrom
aco
Open

feat(storage): enable App-Centric Observability (ACO) support in Otel#13248
nidhiii-27 wants to merge 5 commits into
mainfrom
aco

Conversation

@nidhiii-27

Copy link
Copy Markdown
Contributor

Adding support for App-Centric Observability (ACO) by ensuring GCS spans include the required id and location resource attributes: gcp.resource.destination.id and gcp.resource.destination.location

  • Implemented AcoSpanBuilder and AcoSpan to intercept setAttribute("gsutil.uri", ...), startSpan and endSpan calls
  • Added a package-private BucketMetadataCache using a bounded LinkedHashMap (10,000 entries) to manage bucket-to-location mappings with low memory overhead
  • Triggered asynchronous GetBucket metadata resolution on cache misses using a dedicated ThreadPoolExecutor
  • Managing cache eviction or fallback attributes in case of 404/403

Validated via OtelStorageDecoratorAcoUnitTest and integration tests (ITOpenTelemetryTest, ITOpenTelemetryMPUTest)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a bucket metadata caching mechanism to enrich OpenTelemetry spans with destination resource IDs and locations. It adds AcoSpan and AcoSpanBuilder for span lifecycle management, a BucketMetadataCache for storage, and background fetching logic in OtelStorageDecorator. Reviewer feedback includes using constants for attribute keys, optimizing GCS API calls by selecting specific fields, and reducing the executor shutdown timeout to improve closing efficiency.

@nidhiii-27 nidhiii-27 marked this pull request as ready for review May 21, 2026 09:09
@nidhiii-27 nidhiii-27 requested review from a team as code owners May 21, 2026 09:09
@nidhiii-27 nidhiii-27 requested a review from a team as a code owner June 4, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant