feat(storage): enable App-Centric Observability (ACO) support in Otel#13248
Open
nidhiii-27 wants to merge 5 commits into
Open
feat(storage): enable App-Centric Observability (ACO) support in Otel#13248nidhiii-27 wants to merge 5 commits into
nidhiii-27 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a bucket metadata caching mechanism to enrich OpenTelemetry spans with destination resource IDs and locations. It adds AcoSpan and AcoSpanBuilder for span lifecycle management, a BucketMetadataCache for storage, and background fetching logic in OtelStorageDecorator. Reviewer feedback includes using constants for attribute keys, optimizing GCS API calls by selecting specific fields, and reducing the executor shutdown timeout to improve closing efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for App-Centric Observability (ACO) by ensuring GCS spans include the required id and location resource attributes:
gcp.resource.destination.idandgcp.resource.destination.locationValidated via OtelStorageDecoratorAcoUnitTest and integration tests (ITOpenTelemetryTest, ITOpenTelemetryMPUTest)