feat: API configuration: 20260522T090126Z#15626
Conversation
…le/cloud/networksecurity/v1
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
|
Pull request diff results |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Google.Cloud.NetworkSecurity.V1 library to the generator configuration and pipeline state. The review feedback identifies an inconsistency where the type field should be renamed to transport and set to grpc+rest to align with other entries and support REST functionality. Additionally, it is recommended to provide a description for the library rather than leaving the field empty.
| { | ||
| "id": "Google.Cloud.NetworkSecurity.V1", | ||
| "version": "1.0.0-beta00", | ||
| "type": "grpc", |
There was a problem hiding this comment.
The field name type is inconsistent with other entries in this configuration file, which use transport (see line 4321). Additionally, since restNumericEnums is enabled at line 4342, the library should likely support both gRPC and REST transports to be fully functional.
| "type": "grpc", | |
| "transport": "grpc+rest", |
| "type": "grpc", | ||
| "productName": "Network Security", | ||
| "productUrl": "https://cloud.google.com/products/networking", | ||
| "description": "", |
There was a problem hiding this comment.
The description field is currently empty. It is recommended to provide a brief summary of the library's purpose for better discoverability and documentation.
| "description": "", | |
| "description": "Client library for the Network Security API", |
|
@amanda-tarafa My guess is that the build failure for NumberRegistry may well be dependencies but I haven't looked. |
It's an alpha so we are skipping it for the time being: #15627 |
3 participants
Changes in this PR
Errors