Skip to content

[Code health] Clean up flow of state in SubmissionService #1694

@gino-m

Description

@gino-m
  • Remove select and deselect methods and submissionId state; change submission id via NavigationService instead.
  • Use combineLatestAll to combine at active survey, selected LOI, current user and submissionId$ in NavigationService. Use distinctUntilChanged on the result of combineLatestAll to avoid hitting db multiple times.
  • Emit LOADING when any of the above changes, then loadSubmission$ - use distinctUntilChanged on return value of stream.
  • Remove unused code from MainPageComponent

@rfontanarosa

EDIT: From standup today Oct 23 2024, this above proposal is no longer feasible and needs to be discussed

Metadata

Metadata

Assignees

Labels

type: code healthImprovements to readability or robustness of codebase

Type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions