-
Notifications
You must be signed in to change notification settings - Fork 100
Closed as not planned
Labels
type: code healthImprovements to readability or robustness of codebaseImprovements to readability or robustness of codebase
Milestone
Description
- Remove
selectanddeselectmethods andsubmissionIdstate; change submission id viaNavigationServiceinstead. - Use
combineLatestAllto combine at active survey, selected LOI, current user andsubmissionId$inNavigationService. UsedistinctUntilChangedon the result ofcombineLatestAllto avoid hitting db multiple times. - Emit
LOADINGwhen any of the above changes, then loadSubmission$ - usedistinctUntilChangedon return value of stream. - Remove unused code from
MainPageComponent
EDIT: From standup today Oct 23 2024, this above proposal is no longer feasible and needs to be discussed
Metadata
Metadata
Assignees
Labels
type: code healthImprovements to readability or robustness of codebaseImprovements to readability or robustness of codebase
Type
Projects
Status
Done