test: Use t.Context() instead of context.Background() (#3750)

Author: alexandear

.golangci.yml

@@ -24,6 +24,7 @@ linters:
     - tparallel
     - unconvert
     - unparam
+    - usetesting
     - whitespace
   settings:
     errorlint:
@@ -126,6 +127,14 @@ linters:
       checks:
         - "all"
         - "-QF1008" # allow embedded field in selector
+    usetesting:
+      context-background: true
+      context-todo: true
+      os-chdir: true
+      os-mkdir-temp: true
+      os-setenv: true
+      os-create-temp: true
+      os-temp-dir: true
     custom:
       sliceofpointers:
         type: module

github/actions_artifacts_test.go

@@ -6,7 +6,6 @@
 package github
 
 import (
-	"context"
 	"errors"
 	"fmt"
 	"net/http"
@@ -36,7 +35,7 @@ func TestActionsService_ListArtifacts(t *testing.T) {
 		Name:        Ptr("TheArtifact"),
 		ListOptions: ListOptions{Page: 2},
 	}
-	ctx := context.Background()
+	ctx := t.Context()
 	artifacts, _, err := client.Actions.ListArtifacts(ctx, "o", "r", opts)
 	if err != nil {
 		t.Errorf("Actions.ListArtifacts returned error: %v", err)
@@ -66,7 +65,7 @@ func TestActionsService_ListArtifacts_invalidOwner(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.ListArtifacts(ctx, "%", "r", nil)
 	testURLParseError(t, err)
 }
@@ -75,7 +74,7 @@ func TestActionsService_ListArtifacts_invalidRepo(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.ListArtifacts(ctx, "o", "%", nil)
 	testURLParseError(t, err)
 }
@@ -89,7 +88,7 @@ func TestActionsService_ListArtifacts_notFound(t *testing.T) {
 		w.WriteHeader(http.StatusNotFound)
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	artifacts, resp, err := client.Actions.ListArtifacts(ctx, "o", "r", nil)
 	if err == nil {
 		t.Error("Expected HTTP 404 response")
@@ -118,7 +117,7 @@ func TestActionsService_ListWorkflowRunArtifacts(t *testing.T) {
 	})
 
 	opts := &ListOptions{Page: 2}
-	ctx := context.Background()
+	ctx := t.Context()
 	artifacts, _, err := client.Actions.ListWorkflowRunArtifacts(ctx, "o", "r", 1, opts)
 	if err != nil {
 		t.Errorf("Actions.ListWorkflowRunArtifacts returned error: %v", err)
@@ -148,7 +147,7 @@ func TestActionsService_ListWorkflowRunArtifacts_invalidOwner(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.ListWorkflowRunArtifacts(ctx, "%", "r", 1, nil)
 	testURLParseError(t, err)
 }
@@ -157,7 +156,7 @@ func TestActionsService_ListWorkflowRunArtifacts_invalidRepo(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.ListWorkflowRunArtifacts(ctx, "o", "%", 1, nil)
 	testURLParseError(t, err)
 }
@@ -171,7 +170,7 @@ func TestActionsService_ListWorkflowRunArtifacts_notFound(t *testing.T) {
 		w.WriteHeader(http.StatusNotFound)
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	artifacts, resp, err := client.Actions.ListWorkflowRunArtifacts(ctx, "o", "r", 1, nil)
 	if err == nil {
 		t.Error("Expected HTTP 404 response")
@@ -199,7 +198,7 @@ func TestActionsService_GetArtifact(t *testing.T) {
 		}`)
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	artifact, _, err := client.Actions.GetArtifact(ctx, "o", "r", 1)
 	if err != nil {
 		t.Errorf("Actions.GetArtifact returned error: %v", err)
@@ -235,7 +234,7 @@ func TestActionsService_GetArtifact_invalidOwner(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.GetArtifact(ctx, "%", "r", 1)
 	testURLParseError(t, err)
 }
@@ -244,7 +243,7 @@ func TestActionsService_GetArtifact_invalidRepo(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, _, err := client.Actions.GetArtifact(ctx, "o", "%", 1)
 	testURLParseError(t, err)
 }
@@ -258,7 +257,7 @@ func TestActionsService_GetArtifact_notFound(t *testing.T) {
 		w.WriteHeader(http.StatusNotFound)
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	artifact, resp, err := client.Actions.GetArtifact(ctx, "o", "r", 1)
 	if err == nil {
 		t.Error("Expected HTTP 404 response")
@@ -299,7 +298,7 @@ func TestActionsService_DownloadArtifact(t *testing.T) {
 				http.Redirect(w, r, "https://github.com/artifact", http.StatusFound)
 			})
 
-			ctx := context.Background()
+			ctx := t.Context()
 			url, resp, err := client.Actions.DownloadArtifact(ctx, "o", "r", 1, 1)
 			if err != nil {
 				t.Errorf("Actions.DownloadArtifact returned error: %v", err)
@@ -355,7 +354,7 @@ func TestActionsService_DownloadArtifact_invalidOwner(t *testing.T) {
 			client, _, _ := setup(t)
 			client.RateLimitRedirectionalEndpoints = tc.respectRateLimits
 
-			ctx := context.Background()
+			ctx := t.Context()
 			_, _, err := client.Actions.DownloadArtifact(ctx, "%", "r", 1, 1)
 			testURLParseError(t, err)
 		})
@@ -384,7 +383,7 @@ func TestActionsService_DownloadArtifact_invalidRepo(t *testing.T) {
 			client, _, _ := setup(t)
 			client.RateLimitRedirectionalEndpoints = tc.respectRateLimits
 
-			ctx := context.Background()
+			ctx := t.Context()
 			_, _, err := client.Actions.DownloadArtifact(ctx, "o", "%", 1, 1)
 			testURLParseError(t, err)
 		})
@@ -418,7 +417,7 @@ func TestActionsService_DownloadArtifact_StatusMovedPermanently_dontFollowRedire
 				http.Redirect(w, r, "https://github.com/artifact", http.StatusMovedPermanently)
 			})
 
-			ctx := context.Background()
+			ctx := t.Context()
 			_, resp, _ := client.Actions.DownloadArtifact(ctx, "o", "r", 1, 0)
 			if resp.StatusCode != http.StatusMovedPermanently {
 				t.Errorf("Actions.DownloadArtifact return status %d, want %d", resp.StatusCode, http.StatusMovedPermanently)
@@ -459,7 +458,7 @@ func TestActionsService_DownloadArtifact_StatusMovedPermanently_followRedirects(
 				http.Redirect(w, r, "https://github.com/artifact", http.StatusFound)
 			})
 
-			ctx := context.Background()
+			ctx := t.Context()
 			url, resp, err := client.Actions.DownloadArtifact(ctx, "o", "r", 1, 1)
 			if err != nil {
 				t.Errorf("Actions.DownloadArtifact return error: %v", err)
@@ -507,7 +506,7 @@ func TestActionsService_DownloadArtifact_unexpectedCode(t *testing.T) {
 				w.WriteHeader(http.StatusNoContent)
 			})
 
-			ctx := context.Background()
+			ctx := t.Context()
 			url, resp, err := client.Actions.DownloadArtifact(ctx, "o", "r", 1, 1)
 			if err == nil {
 				t.Fatal("Actions.DownloadArtifact should return error on unexpected code")
@@ -533,7 +532,7 @@ func TestActionsService_DeleteArtifact(t *testing.T) {
 		testMethod(t, r, "DELETE")
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, err := client.Actions.DeleteArtifact(ctx, "o", "r", 1)
 	if err != nil {
 		t.Errorf("Actions.DeleteArtifact return error: %v", err)
@@ -554,7 +553,7 @@ func TestActionsService_DeleteArtifact_invalidOwner(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, err := client.Actions.DeleteArtifact(ctx, "%", "r", 1)
 	testURLParseError(t, err)
 }
@@ -563,7 +562,7 @@ func TestActionsService_DeleteArtifact_invalidRepo(t *testing.T) {
 	t.Parallel()
 	client, _, _ := setup(t)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	_, err := client.Actions.DeleteArtifact(ctx, "o", "%", 1)
 	testURLParseError(t, err)
 }
@@ -577,7 +576,7 @@ func TestActionsService_DeleteArtifact_notFound(t *testing.T) {
 		w.WriteHeader(http.StatusNotFound)
 	})
 
-	ctx := context.Background()
+	ctx := t.Context()
 	resp, err := client.Actions.DeleteArtifact(ctx, "o", "r", 1)
 	if err == nil {
 		t.Error("Expected HTTP 404 response")