|
29 | 29 | from google.adk.a2a.converters.part_converter import convert_a2a_part_to_genai_part |
30 | 30 | from google.adk.a2a.converters.part_converter import convert_genai_part_to_a2a_part |
31 | 31 | from google.adk.a2a.converters.utils import _get_adk_metadata_key |
| 32 | +from google.adk.utils.variant_utils import GoogleLLMVariant |
32 | 33 | from google.genai import types as genai_types |
33 | 34 | import pytest |
34 | 35 |
|
@@ -264,6 +265,138 @@ class UnsupportedPartType: |
264 | 265 | mock_logger.warning.assert_called_once() |
265 | 266 |
|
266 | 267 |
|
| 268 | +class TestConvertA2aPartToGenaiPartApiVariant: |
| 269 | + """Tests for part_metadata suppression based on api_variant (Vertex AI).""" |
| 270 | + |
| 271 | + def _text_part_with_metadata(self): |
| 272 | + return a2a_types.Part( |
| 273 | + root=a2a_types.TextPart( |
| 274 | + text="hello", |
| 275 | + metadata={ |
| 276 | + _get_adk_metadata_key("thought"): True, |
| 277 | + "custom": "value", |
| 278 | + }, |
| 279 | + ) |
| 280 | + ) |
| 281 | + |
| 282 | + def test_text_part_metadata_suppressed_in_vertex_mode(self): |
| 283 | + """In Vertex AI mode, part_metadata must be None to avoid SDK ValueError.""" |
| 284 | + a2a_part = self._text_part_with_metadata() |
| 285 | + |
| 286 | + with patch( |
| 287 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 288 | + return_value=GoogleLLMVariant.VERTEX_AI, |
| 289 | + ): |
| 290 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 291 | + |
| 292 | + assert result is not None |
| 293 | + assert result.part_metadata is None |
| 294 | + # Native fields are still populated from the metadata. |
| 295 | + assert result.text == "hello" |
| 296 | + assert result.thought is True |
| 297 | + |
| 298 | + def test_text_part_metadata_preserved_in_gemini_api_mode(self): |
| 299 | + """In Gemini Developer API mode, part_metadata is preserved.""" |
| 300 | + a2a_part = self._text_part_with_metadata() |
| 301 | + |
| 302 | + with patch( |
| 303 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 304 | + return_value=GoogleLLMVariant.GEMINI_API, |
| 305 | + ): |
| 306 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 307 | + |
| 308 | + assert result is not None |
| 309 | + assert result.part_metadata == { |
| 310 | + _get_adk_metadata_key("thought"): True, |
| 311 | + "custom": "value", |
| 312 | + } |
| 313 | + |
| 314 | + def test_function_call_metadata_suppressed_in_vertex_mode(self): |
| 315 | + """Function call data parts also suppress part_metadata in Vertex mode.""" |
| 316 | + a2a_part = a2a_types.Part( |
| 317 | + root=a2a_types.DataPart( |
| 318 | + data={"name": "my_func", "args": {"x": 1}}, |
| 319 | + metadata={ |
| 320 | + _get_adk_metadata_key( |
| 321 | + A2A_DATA_PART_METADATA_TYPE_KEY |
| 322 | + ): A2A_DATA_PART_METADATA_TYPE_FUNCTION_CALL, |
| 323 | + "custom": "value", |
| 324 | + }, |
| 325 | + ) |
| 326 | + ) |
| 327 | + |
| 328 | + with patch( |
| 329 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 330 | + return_value=GoogleLLMVariant.VERTEX_AI, |
| 331 | + ): |
| 332 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 333 | + |
| 334 | + assert result is not None |
| 335 | + assert result.function_call is not None |
| 336 | + assert result.part_metadata is None |
| 337 | + |
| 338 | + def test_function_response_metadata_suppressed_in_vertex_mode(self): |
| 339 | + """Function response data parts suppress part_metadata in Vertex mode.""" |
| 340 | + a2a_part = a2a_types.Part( |
| 341 | + root=a2a_types.DataPart( |
| 342 | + data={"name": "my_func", "response": {"ok": True}}, |
| 343 | + metadata={ |
| 344 | + _get_adk_metadata_key( |
| 345 | + A2A_DATA_PART_METADATA_TYPE_KEY |
| 346 | + ): A2A_DATA_PART_METADATA_TYPE_FUNCTION_RESPONSE, |
| 347 | + "custom": "value", |
| 348 | + }, |
| 349 | + ) |
| 350 | + ) |
| 351 | + |
| 352 | + with patch( |
| 353 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 354 | + return_value=GoogleLLMVariant.VERTEX_AI, |
| 355 | + ): |
| 356 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 357 | + |
| 358 | + assert result is not None |
| 359 | + assert result.function_response is not None |
| 360 | + assert result.part_metadata is None |
| 361 | + |
| 362 | + def test_file_with_uri_metadata_suppressed_in_vertex_mode(self): |
| 363 | + """File parts suppress part_metadata in Vertex mode.""" |
| 364 | + a2a_part = a2a_types.Part( |
| 365 | + root=a2a_types.FilePart( |
| 366 | + file=a2a_types.FileWithUri( |
| 367 | + uri="gs://bucket/file.txt", |
| 368 | + mime_type="text/plain", |
| 369 | + name="my_file.txt", |
| 370 | + ), |
| 371 | + metadata={"custom": "value"}, |
| 372 | + ) |
| 373 | + ) |
| 374 | + |
| 375 | + with patch( |
| 376 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 377 | + return_value=GoogleLLMVariant.VERTEX_AI, |
| 378 | + ): |
| 379 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 380 | + |
| 381 | + assert result is not None |
| 382 | + assert result.file_data is not None |
| 383 | + assert result.part_metadata is None |
| 384 | + |
| 385 | + def test_api_variant_resolved_from_env(self): |
| 386 | + """The api variant is resolved via get_google_llm_variant.""" |
| 387 | + a2a_part = self._text_part_with_metadata() |
| 388 | + |
| 389 | + with patch( |
| 390 | + "google.adk.a2a.converters.part_converter.get_google_llm_variant", |
| 391 | + return_value=GoogleLLMVariant.VERTEX_AI, |
| 392 | + ) as mock_get_variant: |
| 393 | + result = convert_a2a_part_to_genai_part(a2a_part) |
| 394 | + |
| 395 | + mock_get_variant.assert_called_once() |
| 396 | + assert result is not None |
| 397 | + assert result.part_metadata is None |
| 398 | + |
| 399 | + |
267 | 400 | class TestConvertGenaiPartToA2aPart: |
268 | 401 | """Test cases for convert_genai_part_to_a2a_part function.""" |
269 | 402 |
|
|
0 commit comments