Skip to content

"Empty-text-only chunk suppression" fix (b4791ef) was reverted by 69638df before v1.4.0 — fix not actually in the release #1250

@DylanChen1996

Description

@DylanChen1996

Summary

The fix "Suppress empty-text-only chunks from streaming responses while preserving carried metadata" (b4791ef) is listed in the v1.4.0 changelog but was subsequently reverted by 69638df — and both commits landed in v1.4.0. The net effect is that the fix is not actually present in the v1.4.0 release.

Details

Commit timeline (all on main, all in v1.4.0)

Commit Date Description
b4791ef 2026-05-19 fix: Suppress empty-text-only chunks from streaming responses while preserving carried metadata
384a0c5 2026-05-20 feat: Add streaming support for ChatCompletionsHTTPClient
69638df 2026-05-21 fix: revert "Suppress empty-text-only chunks from streaming responses while preserving carried metadata"

The revert (69638df) was authored by @damianmomot on May 21, two days after the original fix, and is a direct child of 384a0c5. Its commit message cites PiperOrigin-RevId: 918887561.

What the revert removed

The revert stripped 266 lines across two files:

  • Gemini.java: ~100 lines of the empty-chunk suppression logic
  • GeminiTest.java: 182 lines of corresponding tests

Git ancestry confirms both are in v1.4.0

$ git merge-base --is-ancestor b4791ef3 v1.4.0 && echo "yes"  → yes
$ git merge-base --is-ancestor 69638df9 v1.4.0 && echo "yes"  → yes
$ git log --oneline --ancestry-path b4791ef3..v1.4.0 | grep 69638df
69638df9 fix: revert "Suppress empty-text-only chunks..."

The revert sits directly on the ancestry path between the original fix and the v1.4.0 tag, meaning the fix is effectively not in the release.

CHANGELOG

The current CHANGELOG.md lists both entries, which is technically accurate, but readers skimming the release notes may miss that the second entry cancels out the first. The GitHub release page may only surface the "Suppress empty-text-only chunks" entry without the revert context.

Expected behavior

Either:

  1. The fix should be re-applied (if the revert was unintentional or the underlying issue was resolved).
  2. Or the changelog / release notes should clearly indicate that the fix was reverted and is not included in v1.4.0, to avoid confusion for users upgrading in expectation of this fix.

Additional context

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions