Blast Corps black artifacts

[m4xw]

Hello @gonetz
Just wanted to let you know that at least on mupen nx in blast corps the hack isnt working properly in setBlendMode

With legacy blending it "works" but the banners / logo disappear too, without legacy blending for me the artifacts appear like the hack isnt running at all.

I fixed it by just changing the hack to:

const u32 blendmode = gDP.otherMode.l >> 16;
bool blastCorpsHack = (config.generalEmulation.hacks & hack_blastCorps) != 0 &&
					  gSP.texture.on == 0 && gDP.otherMode.cycleType < G_CYC_COPY && currentCombiner()->usesTexture() &&
					  blendmode != 0x0050;

Doubt its correct, maybe you can take a look whats going on there?

[m4xw]

Upon further investigation this seems to be caused by blendmode 0x0000

[m4xw]

Further research shows this happens with fbemu on but copy aux to rdram off

[gonetz]

The original hack detects the following situation: texturing is disabled by color combiner uses texture input.
The plugin can't render such polygons properly, so it just setups blender to make them invisible.
If you still see the black artifacts, some of the conditions doesn't work.
Your blendmode != 0x0050 fix adds another condition and thus makes this hack applicable for even less number of polygons.
You'd better check, if the original hack condition triggers at all. Probably, with mupen nx the gSP.texture.on == 0 condition doesn't satisfied, for example because it uses LLE mode.