fix(core): preserve error properties for Astro's error overlay enrichment

aminevg · aminevg · commit ef5d94cd1a58 · 2026-03-16T23:06:43.000+09:00
Pass through loc, hint, frame, fullCode, plugin, pluginCode, id, and cause
from the original error to the WebSocket payload. Astro's module loader
intercepts hot.send() and calls collectErrorMetadata() + getViteErrorPayload()
to enrich the overlay — but only if these properties are present. Without them,
the overlay was missing source code highlighting, error carets, and hints.
diff --git a/packages/core/src/dev/setup.ts b/packages/core/src/dev/setup.ts
@@ -8,7 +8,7 @@ import {
 } from "astro";
 import { mergeConfig } from "astro/config";
 import type { Element } from "hast";
-import type { ViteDevServer } from "vite";
+import type { ErrorPayload, ViteDevServer } from "vite";
 import { getStylesForURL } from "@/dev/css";
 import type {
   MightyDevMiddleware,
@@ -217,19 +217,38 @@ export async function setupDev(
           throw error;
         }
 
+        const err = error as Error & Record<string, unknown>;
+
+        // Send error to Astro's error overlay via WebSocket.
+        // Astro's module loader intercepts hot.send() and enriches the payload
+        // with source code highlighting, hints, and docs links via
+        // collectErrorMetadata() + getViteErrorPayload().
+        // We preserve all error properties (loc, hint, frame, etc.) so the
+        // enrichment has full context — especially for AstroError subclasses.
+        const errPayload: ErrorPayload = {
+          type: "error",
+          err: {
+            name: err.name,
+            message: err.message,
+            stack: err.stack ?? "",
+            loc: err.loc,
+            hint: err.hint,
+            frame: err.frame,
+            fullCode: err.fullCode,
+            plugin: err.plugin,
+            pluginCode: err.pluginCode,
+            id: err.id,
+            cause: err.cause,
+          } as ErrorPayload["err"],
+        };
+
         setTimeout(() => {
-          viteServer.environments.client.hot.send({
-            type: "error",
-            err: {
-              message: (error as Error).message,
-              stack: (error as Error).stack ?? "",
-            },
-          });
+          viteServer.environments.client.hot.send(errPayload);
         }, 200);
 
         return {
           status: 500,
-          content: `<html><head><title>${(error as Error).name}</title><script type="module" src="${request.address}/@vite/client"></script></head><body></body></html>`,
+          content: `<html><head><title>${err.name}</title><script type="module" src="${request.address}/@vite/client"></script></head><body></body></html>`,
         };
       }
     },
