Extra newline added in the middle of list

[laurelschmidt]

If a list contains sub-lists, an extra newline gets added inappropriately between list items. Code to reproduce:

package main

import (
	"fmt"

	"github.com/gomarkdown/markdown"
	"github.com/gomarkdown/markdown/md"
	"github.com/gomarkdown/markdown/parser"
)

func testGomarkdown(input []byte) []byte {
	extensions := parser.NoIntraEmphasis | parser.Tables | parser.FencedCode | parser.Strikethrough | parser.SpaceHeadings | parser.HeadingIDs | parser.DefinitionLists | parser.AutoHeadingIDs | parser.NoEmptyLineBeforeBlock
	p := parser.NewWithExtensions(extensions)
	tree := p.Parse(input)

	renderer := md.NewRenderer()
	return markdown.Render(tree, renderer)
}

func main() {
	testStr := "# Main Header\n\n## First Subsection\n\n*Content of first subsection.\n* More\n    * Yet more"
	output := testGomarkdown([]byte(testStr))
	if string(output) != testStr {
		fmt.Printf("Test string was modified during parsing and rendering. Expected:\n\n%q\n\nGot:\n\n%q", testStr, string(output))
	} else {
		fmt.Println("Test string is return unmodified.")
	}
}

Output (note the extra newline before "* More"):

Test string was modified during parsing and rendering. Expected:

"# Main Header\n\n## First Subsection\n\nContent of first subsection.\n More\n * Yet more"

Got:

"# Main Header\n\n## First Subsection\n\nContent of first subsection.\n\n More\n * Yet more\n\n\n"

[laurelschmidt]

@tobias-kuendig it looks like you added a test case in TestRenderList that says the expected rendering of an unordered list with a sub-list in the middle is to have two newlines after the end of the sub-list:

(from playground)

Commit: fe0b4be
PR: #332

It looks like the main goal of that PR was to fix newlines after lists, and the CommonMark Tutorial shows examples of sub-lists within a list that aren't followed by a newline. Are you ok with me getting rid of that newline in the middle of the list and updating the associated test case?

[tobias-kuendig]

Not sure I'm the right person to answer your question, since I only provided a PR. Maybe @kjk can chime in.

[laurelschmidt]

@kjk are you ok with me changing this behavior? It looks to me like an unintended side-effect of the other change, and I don't think the current behavior is what consumers would want. Currently, running this through the markdown parsers and renderer:

• here's a list
  • with a sub-list
• and the main list continues

turns it into this:

• here's a list

  • with a sub-list

• and the main list continues

(note the extra newline after the sub-list). I would like to make it render the same as the input.

[kjk]

Sure go ahead

…

On Thu, Jul 31, 2025 at 22:02 laurelschmidt ***@***.***> wrote: *laurelschmidt* left a comment (gomarkdown/markdown#340) <#340 (comment)> @kjk <https://github.com/kjk> are you ok with me changing this behavior? It looks to me like an unintended side-effect of the other change, and I don't think the current behavior is what consumers would want. Currently, running this through the markdown parsers and renderer: - here's a list - with a sub-list - and the main list continues turns it into this: - here's a list - with a sub-list - and the main list continues (note the extra newline after the sub-list). I would like to make it render the same as the input. — Reply to this email directly, view it on GitHub <#340 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAB577PEVOAKFVW2OQARQT3LJY7FAVCNFSM6AAAAACBVQMP3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBRGE4DQNZYHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[laurelschmidt]

Done in #345