Skip to content

Commit 0164f7a

Browse files
rpuneetclaude
andcommitted
Merge origin/main - resolve conflicts
Resolved conflicts: - api_integration_test.go: kept UserComment type as string (Bug #19 fix), accepted Canon ExactTagCount: -1 from main - tiff.go: accepted fujifilm registration from main alongside canon Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 parents dae2c42 + 02f42c3 commit 0164f7a

7 files changed

Lines changed: 841 additions & 46 deletions

File tree

api_integration_test.go

Lines changed: 4 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,8 @@ func TestIntegration_CR2(t *testing.T) {
282282
{Name: "MeteringMode", Value: "Multi-segment"},
283283
{Name: "Flash", Value: "Off, Did not fire"},
284284
{Name: "FocalLength", Value: "85/1"},
285-
// MakerNote is now parsed into Canon directory (see below)
286-
{Name: "UserComment", Type: "string"}, // Decoded comment text
285+
// MakerNote is now parsed into Canon directory
286+
{Name: "UserComment", Type: "string"}, // Decoded comment text (Bug #19 fix)
287287
{Name: "FlashpixVersion", Value: "0100"},
288288
{Name: "ColorSpace", Value: "sRGB"},
289289
{Name: "PixelXDimension", Value: uint16(4992)},
@@ -306,40 +306,8 @@ func TestIntegration_CR2(t *testing.T) {
306306
},
307307
},
308308
{
309-
Name: "Canon", // MakerNote parsed into manufacturer directory
310-
ExactTagCount: 28, // All Canon MakerNote tags
311-
Tags: []imxtest.TagExpectation{
312-
// Check key tags with exact values
313-
{Name: "ImageType", Value: "Canon EOS-1Ds Mark II"},
314-
{Name: "FirmwareVersion", Value: "Firmware Version 1.0.2"},
315-
{Name: "SerialNumber", Value: uint32(304421)},
316-
// All other Canon tags (presence check only)
317-
{Name: "CameraSettings"},
318-
{Name: "FocalLength"},
319-
{Name: "FlashInfo"},
320-
{Name: "ShotInfo"},
321-
{Name: "OwnerName"},
322-
{Name: "CameraInfo"},
323-
{Name: "CustomFunctions"},
324-
{Name: "ModelID"},
325-
{Name: "AFInfo"},
326-
{Name: "ThumbnailImageValidArea"},
327-
{Name: "SerialNumberFormat"},
328-
{Name: "0x0019"},
329-
{Name: "OriginalDecisionDataOffset"},
330-
{Name: "PersonalFunctions"},
331-
{Name: "PersonalFunctionValues"},
332-
{Name: "CanonFileInfo"},
333-
{Name: "AFPointsInFocus1D"},
334-
{Name: "ProcessingInfo"},
335-
{Name: "MeasuredColor"},
336-
{Name: "SensorInfo"},
337-
{Name: "VRDOffset"},
338-
{Name: "ColorData"},
339-
{Name: "CRWParam"},
340-
{Name: "ColorInfo"},
341-
{Name: "0x4004"},
342-
},
309+
Name: "Canon",
310+
ExactTagCount: -1, // Presence check only - Canon MakerNote content varies by camera model
343311
},
344312
})
345313
if result.Failed() {

0 commit comments

Comments
 (0)