cmd: apply modernizers

Apply modernizers to all the files in the x/tools/cmd tree.
Also suppress most warnings.

Change-Id: I6cd80200f423e79971cedbc64cd731300e65c834
Reviewed-on: https://go-review.googlesource.com/c/tools/+/641355
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

Author: pjweinbgo

cmd/benchcmp/benchcmp.go

@@ -133,7 +133,7 @@ func main() {
 	}
 }
 
-func fatal(msg interface{}) {
+func fatal(msg any) {
 	fmt.Fprintln(os.Stderr, msg)
 	os.Exit(1)
 }

cmd/bundle/main_test.go

@@ -27,15 +27,15 @@ func testBundle(t *testing.T, x packagestest.Exporter) {
 	e := packagestest.Export(t, x, []packagestest.Module{
 		{
 			Name: "initial",
-			Files: map[string]interface{}{
+			Files: map[string]any{
 				"a.go": load("testdata/src/initial/a.go"),
 				"b.go": load("testdata/src/initial/b.go"),
 				"c.go": load("testdata/src/initial/c.go"),
 			},
 		},
 		{
 			Name: "domain.name/importdecl",
-			Files: map[string]interface{}{
+			Files: map[string]any{
 				"p.go": load("testdata/src/domain.name/importdecl/p.go"),
 			},
 		},

cmd/godex/godex.go

@@ -84,7 +84,7 @@ func main() {
 	}
 }
 
-func logf(format string, args ...interface{}) {
+func logf(format string, args ...any) {
 	if *verbose {
 		fmt.Fprintf(os.Stderr, format, args...)
 	}

cmd/godex/print.go

@@ -48,7 +48,7 @@ func (p *printer) print(s string) {
 	}
 }
 
-func (p *printer) printf(format string, args ...interface{}) {
+func (p *printer) printf(format string, args ...any) {
 	p.print(fmt.Sprintf(format, args...))
 }
 

cmd/godex/writetype.go

@@ -111,7 +111,7 @@ func (p *printer) writeTypeInternal(this *types.Package, typ types.Type, visited
 		//
 		n := t.NumMethods()
 		if n == 0 {
-			p.print("interface{}")
+			p.print("any")
 			return
 		}
 

cmd/godoc/godoc_test.go

@@ -71,14 +71,14 @@ func serverAddress(t *testing.T) string {
 	return ln.Addr().String()
 }
 
-func waitForServerReady(t *testing.T, ctx context.Context, cmd *exec.Cmd, addr string) {
+func waitForServerReady(t *testing.T, ctx context.Context, addr string) {
 	waitForServer(t, ctx,
 		fmt.Sprintf("http://%v/", addr),
 		"Go Documentation Server",
 		false)
 }
 
-func waitForSearchReady(t *testing.T, ctx context.Context, cmd *exec.Cmd, addr string) {
+func waitForSearchReady(t *testing.T, ctx context.Context, _ *exec.Cmd, addr string) {
 	waitForServer(t, ctx,
 		fmt.Sprintf("http://%v/search?q=FALLTHROUGH", addr),
 		"The list of tokens.",
@@ -208,15 +208,15 @@ func testWeb(t *testing.T, x packagestest.Exporter, bin string, withIndex bool)
 	e := packagestest.Export(t, x, []packagestest.Module{
 		{
 			Name: "godoc.test/repo1",
-			Files: map[string]interface{}{
+			Files: map[string]any{
 				"a/a.go": `// Package a is a package in godoc.test/repo1.
 package a; import _ "godoc.test/repo2/a"; const Name = "repo1a"`,
 				"b/b.go": `package b; const Name = "repo1b"`,
 			},
 		},
 		{
 			Name: "godoc.test/repo2",
-			Files: map[string]interface{}{
+			Files: map[string]any{
 				"a/a.go": `package a; const Name = "repo2a"`,
 				"b/b.go": `package b; const Name = "repo2b"`,
 			},
@@ -261,7 +261,7 @@ package a; import _ "godoc.test/repo2/a"; const Name = "repo1a"`,
 	if withIndex {
 		waitForSearchReady(t, ctx, cmd, addr)
 	} else {
-		waitForServerReady(t, ctx, cmd, addr)
+		waitForServerReady(t, ctx, addr)
 		waitUntilScanComplete(t, ctx, addr)
 	}
 

cmd/gotype/gotype.go

@@ -185,7 +185,7 @@ func report(err error) {
 }
 
 // parse may be called concurrently
-func parse(filename string, src interface{}) (*ast.File, error) {
+func parse(filename string, src any) (*ast.File, error) {
 	if *verbose {
 		fmt.Println(filename)
 	}

cmd/goyacc/yacc.go

@@ -52,6 +52,7 @@ import (
 	"go/format"
 	"math"
 	"os"
+	"slices"
 	"strconv"
 	"strings"
 	"unicode"
@@ -2323,7 +2324,7 @@ func wrstate(i int) {
 	var pp, qq int
 
 	if len(errors) > 0 {
-		actions := append([]int(nil), temp1...)
+		actions := slices.Clone(temp1)
 		defaultAction := ERRCODE
 		if lastred != 0 {
 			defaultAction = -lastred
@@ -3176,7 +3177,7 @@ func create(s string) *bufio.Writer {
 }
 
 // write out error comment
-func lerrorf(lineno int, s string, v ...interface{}) {
+func lerrorf(lineno int, s string, v ...any) {
 	nerrors++
 	fmt.Fprintf(stderr, s, v...)
 	fmt.Fprintf(stderr, ": %v:%v\n", infile, lineno)
@@ -3186,7 +3187,7 @@ func lerrorf(lineno int, s string, v ...interface{}) {
 	}
 }
 
-func errorf(s string, v ...interface{}) {
+func errorf(s string, v ...any) {
 	lerrorf(lineno, s, v...)
 }
 

cmd/signature-fuzzer/fuzz-driver/driver.go

@@ -59,7 +59,7 @@ var selbadfcnflag = flag.Int("badfcnidx", 0, "[Testing only] select index of bad
 var goimpflag = flag.Bool("goimports", false, "Run 'goimports' on generated code.")
 var randctlflag = flag.Int("randctl", generator.RandCtlChecks|generator.RandCtlPanic, "Wraprand control flag")
 
-func verb(vlevel int, s string, a ...interface{}) {
+func verb(vlevel int, s string, a ...any) {
 	if *verbflag >= vlevel {
 		fmt.Printf(s, a...)
 		fmt.Printf("\n")

cmd/signature-fuzzer/fuzz-runner/rnr_test.go

@@ -16,7 +16,7 @@ import (
 	"golang.org/x/tools/internal/testenv"
 )
 
-func canRace(t *testing.T) bool {
+func canRace() bool {
 	_, err := exec.Command("go", "run", "-race", "./testdata/himom.go").CombinedOutput()
 	return err == nil
 }
@@ -70,7 +70,7 @@ func testRace(t *testing.T, binaryPath string) {
 	// For this test to work, the current test platform has to support the
 	// race detector. Check to see if that is the case by running a very
 	// simple Go program through it.
-	if !canRace(t) {
+	if !canRace() {
 		t.Skip("current platform does not appear to support the race detector")
 	}