semaphore: better error message when releasing more than held

jeanbza · bradfitz · commit 112230192c58 · 2019-04-23T02:48:10.000Z
Change-Id: Ibe69007b2d7565a33d9e64ae51142478f495509a Reviewed-on: https://go-review.googlesource.com/c/sync/+/173377 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/semaphore/semaphore.go b/semaphore/semaphore.go
@@ -95,7 +95,7 @@ func (s *Weighted) Release(n int64) {
 	s.cur -= n
 	if s.cur < 0 {
 		s.mu.Unlock()
-		panic("semaphore: bad release")
+		panic("semaphore: released more than held")
 	}
 	for {
 		next := s.waiters.Front()

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ func (s *Weighted) Release(n int64) {`
`95`	`95`	`s.cur -= n`
`96`	`96`	`if s.cur < 0 {`
`97`	`97`	`s.mu.Unlock()`
`98`		`- panic("semaphore: bad release")`
	`98`	`+ panic("semaphore: released more than held")`
`99`	`99`	`}`
`100`	`100`	`for {`
`101`	`101`	`next := s.waiters.Front()`