ssh: disable client agent tests on Windows

drakkan · gopherbot · commit 5df3b5994134 · 2023-07-13T13:29:36.000Z
ssh-agent is implemented as a Windows service and exposed on a named pipe. We don't currently support it. See golang/go#60981 Change-Id: Iebdc42db30b37a87ac0766231b16aff3f17b3f56 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/509035 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/ssh/agent/client_test.go b/ssh/agent/client_test.go
@@ -29,6 +29,9 @@ func startOpenSSHAgent(t *testing.T) (client ExtendedAgent, socket string, clean
 		// types supported vary by platform.
 		t.Skip("skipping test due to -short")
 	}
+	if runtime.GOOS == "windows" {
+		t.Skip("skipping on windows, we don't support connecting to the ssh-agent via a named pipe")
+	}
 
 	bin, err := exec.LookPath("ssh-agent")
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,9 @@ func startOpenSSHAgent(t *testing.T) (client ExtendedAgent, socket string, clean`
`29`	`29`	`// types supported vary by platform.`
`30`	`30`	`t.Skip("skipping test due to -short")`
`31`	`31`	`}`
	`32`	`+ if runtime.GOOS == "windows" {`
	`33`	`+ t.Skip("skipping on windows, we don't support connecting to the ssh-agent via a named pipe")`
	`34`	`+ }`
`32`	`35`
`33`	`36`	`bin, err := exec.LookPath("ssh-agent")`
`34`	`37`	`if err != nil {`