Merge pull request #68 from gobackup/fix/fix-code-review-stage

Enhance code review prompt and check if there is any issue to comment

Author: payamQorbanpour

.github/workflows/ai-review.yml

@@ -66,15 +66,7 @@ jobs:
           DIFF_CONTENT=$(cat pr_diff.txt | jq -Rs .)
           
           # Prepare the review prompt
-          PROMPT="You are an expert code reviewer. Please review the following code changes and provide:
-          1. A summary of the changes
-          2. Potential issues or bugs
-          3. Security concerns if any
-          4. Performance considerations
-          5. Best practices and suggestions for improvement
-          6. Positive aspects of the code
-          
-          Focus on Go code, Kubernetes manifests, and Helm charts.
+          PROMPT="Act as a senior Go and Kubernetes engineer. Review the diff and point out only real bugs, security concerns, or risky changes. Keep the review concise and specific, referencing files or resources when it helps. If there is nothing actionable to flag, respond with NO_ISSUES and nothing else.
           
           Code diff:
           $DIFF_CONTENT"
@@ -101,34 +93,39 @@ jobs:
             }")
           
           # Extract the review content
-          REVIEW=$(echo "$RESPONSE" | jq -r '.choices[0].message.content // "Error: Unable to get AI review"')
-          
-          # Save review to file
-          echo "$REVIEW" > review.txt
-          
-          # Check for API errors
+          REVIEW=$(echo "$RESPONSE" | jq -r '.choices[0].message.content // ""')
+          HAS_ISSUES=false
+
           if echo "$RESPONSE" | jq -e '.error' > /dev/null 2>&1; then
             ERROR_MSG=$(echo "$RESPONSE" | jq -r '.error.message // "Unknown error"')
-            echo "API Error: $ERROR_MSG"
-            echo "API Error: $ERROR_MSG" > review.txt
+            REVIEW="AI review failed: $ERROR_MSG"
+            HAS_ISSUES=false
+          else
+            TRIMMED=$(echo "$REVIEW" | tr -d '[:space:]')
+            if [ -z "$TRIMMED" ] || [ "$TRIMMED" = "NO_ISSUES" ]; then
+              HAS_ISSUES=false
+              REVIEW="NO_ISSUES"
+            else
+              HAS_ISSUES=true
+            fi
           fi
+
+          # Save review to file
+          echo "$REVIEW" > review.txt
+          echo "has_issues=$HAS_ISSUES" >> "$GITHUB_OUTPUT"
       
       - name: Post AI Review Comment
-        if: always()
+        if: steps.ai-review.outputs.has_issues == 'true'
         uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
             const fs = require('fs');
-            const reviewContent = fs.readFileSync('review.txt', 'utf8');
-            
-            const comment = `## 🤖 AI Code Review
-            
-            ${reviewContent}
-            
-            ---
-            *This review was automatically generated by AI. Please use your judgment and verify the suggestions.*`;
-            
+            const reviewContent = fs.readFileSync('review.txt', 'utf8').trim();
+            const marker = '<!-- ai-review -->';
+            const header = '### AI Code Review (automated)\n\n';
+            const comment = `${header}${reviewContent}\n\n${marker}`;
+
             // Check if there's already an AI review comment
             const { data: comments } = await github.rest.issues.listComments({
               owner: context.repo.owner,
@@ -138,7 +135,7 @@ jobs:
             
             const botComment = comments.find(comment => 
               comment.user.type === 'Bot' && 
-              comment.body.includes('🤖 AI Code Review')
+              comment.body.includes(marker)
             );
             
             if (botComment) {