refactoring and micro-optimisation

Author: julienschmidt

connection.go

@@ -18,7 +18,9 @@ import (
 
 type mysqlConn struct {
 	cfg          *config
-	server       *serverSettings
+	flags        ClientFlag
+	charset      byte
+	scrambleBuff []byte
 	netConn      net.Conn
 	buf          *buffer
 	protocol     uint8
@@ -36,15 +38,6 @@ type config struct {
 	params map[string]string
 }
 
-type serverSettings struct {
-	protocol     byte
-	version      string
-	flags        ClientFlag
-	charset      uint8
-	scrambleBuff []byte
-	threadID     uint32
-}
-
 // Handles parameters set in DSN
 func (mc *mysqlConn) handleParams() (err error) {
 	for param, val := range mc.cfg.params {

driver_test.go

@@ -301,7 +301,7 @@ func TestString(t *testing.T) {
 		if rows.Next() {
 			rows.Scan(&out)
 			if in != out {
-				t.Errorf("%s: %d != %d", v, in, out)
+				t.Errorf("%s: %s != %s", v, in, out)
 			}
 		} else {
 			t.Errorf("%s: no data", v)

errors.go

@@ -0,0 +1,19 @@
+// Go MySQL Driver - A MySQL-Driver for Go's database/sql package
+//
+// Copyright 2013 Julien Schmidt. All rights reserved.
+// http://www.julienschmidt.com
+//
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at http://mozilla.org/MPL/2.0/.
+
+package mysql
+
+import "errors"
+
+var (
+	errMalformPkt  = errors.New("Malformed Packet")
+	errPktSync     = errors.New("Commands out of sync. You can't run this command now")
+	errPktSyncMul  = errors.New("Commands out of sync. Did you run multiple statements at once?")
+	errOldPassword = errors.New("It seems like you are using old_passwords, which is unsupported. See https://github.com/Go-SQL-Driver/MySQL/wiki/old_passwords")
+)