client/pool: add Option to supply custom Dialer (#1086)

Author: olivierboucher

client/pool.go

@@ -5,6 +5,7 @@ import (
 	"log/slog"
 	"math"
 	"math/rand"
+	"net"
 	"sync"
 	"time"
 
@@ -118,7 +119,7 @@ func NewPoolWithOptions(
 		idlePingTimeout:  Timestamp(math.Ceil(MaxIdleTimeoutWithoutPing.Seconds())),
 
 		connect: func() (*Conn, error) {
-			return Connect(addr, user, password, dbName, po.connOptions...)
+			return ConnectWithDialer(context.Background(), "", addr, user, password, dbName, po.dialer, po.connOptions...)
 		},
 
 		readyConnection: make(chan Connection),
@@ -606,10 +607,12 @@ func (pool *Pool) checkConnection(ctx context.Context) error {
 
 // getDefaultPoolOptions returns pool config for low load services
 func getDefaultPoolOptions() poolOptions {
+	dialer := &net.Dialer{Timeout: 10 * time.Second}
 	return poolOptions{
 		logger:   slog.Default(),
 		minAlive: 1,
 		maxAlive: 10,
 		maxIdle:  2,
+		dialer:   dialer.DialContext,
 	}
 }

client/pool_options.go

@@ -18,6 +18,8 @@ type (
 		password string
 		dbName   string
 
+		dialer Dialer
+
 		connOptions []Option
 
 		newPoolPingTimeout time.Duration
@@ -59,3 +61,9 @@ func WithNewPoolPingTimeout(timeout time.Duration) PoolOption {
 		o.newPoolPingTimeout = timeout
 	}
 }
+
+func WithDialer(dialer Dialer) PoolOption {
+	return func(o *poolOptions) {
+		o.dialer = dialer
+	}
+}