Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions script/generate-plpgsql-grammar.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ module.exports = grammar({
),

decl_statement: $ => choice(
// Alias declaration: name ALIAS FOR target ;
// Must precede variable declaration so ALIAS is not consumed as a type name.
seq($.decl_varname, $.kw_alias, $.kw_for, $.any_identifier, ';'),
// Variable declaration: name [CONSTANT] type [COLLATE collation] [NOT NULL] [DEFAULT|:=|= expr] ;
seq(
$.decl_varname,
Expand All @@ -206,8 +209,6 @@ module.exports = grammar({
optional($.decl_defval),
';'
),
// Alias declaration: name ALIAS FOR target ;
seq($.decl_varname, $.kw_alias, $.kw_for, $.any_identifier, ';'),
// Cursor declaration: name [NO SCROLL | SCROLL] CURSOR [(args)] FOR|IS query ;
seq(
$.decl_varname,
Expand Down Expand Up @@ -560,7 +561,8 @@ module.exports = grammar({
stmt_fetch: $ => seq(
$.kw_fetch,
optional($.fetch_direction),
optional(seq($.kw_from, $.any_identifier)),
optional($.kw_from),
$.any_identifier,
$.kw_into,
$.into_target,
';'
Expand Down
35 changes: 35 additions & 0 deletions script/generate-plpgsql-grammar.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
'use strict';

const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const { test } = require('node:test');

const projectRoot = path.join(__dirname, '..');

function readRepoFile(relativePath) {
return fs.readFileSync(path.join(projectRoot, relativePath), 'utf8');
}

function extractTopLevelRule(source, ruleName) {
const pattern = new RegExp(
String.raw`^ ${ruleName}: \$ => [\s\S]*?^ \),`,
'm'
);
const match = source.match(pattern);
assert.ok(match, `Could not find top-level rule ${ruleName}`);
return match[0].trimEnd();
}

test('PL/pgSQL generator template matches committed grammar for drift-sensitive rules', () => {
const generator = readRepoFile('script/generate-plpgsql-grammar.js');
const grammar = readRepoFile('plpgsql/grammar.js');

for (const ruleName of ['decl_statement', 'stmt_fetch']) {
assert.equal(
extractTopLevelRule(generator, ruleName),
extractTopLevelRule(grammar, ruleName),
`${ruleName} differs between script/generate-plpgsql-grammar.js and plpgsql/grammar.js`
);
}
});
Loading