Skip to content

Auto-built containers don't have git version info #98

@JohnStrunk

Description

@JohnStrunk

Describe the bug
The current method used to build in docker cloud doesn't set the build args properly, so some are left blank. Of particular importance are the version and build-date labels.

Steps to reproduce

$ skopeo inspect docker://docker.io/gluster/gluster-csi-driver
{
    "Name": "docker.io/gluster/gluster-csi-driver",
    "Digest": "sha256:7c3c4b360c1341912837c736173ff874b13536abdd53eaaa35febce761363e26",
    "RepoTags": [
        "latest"
    ],
    "Created": "2018-11-13T21:10:45.810160207Z",
    "DockerVersion": "18.03.1-ee-3",
    "Labels": {
        "Summary": "FUSE-based CSI driver for Gluster file access",
        "build-date": "(unknown)",
        "io.k8s.description": "FUSE-based CSI driver for Gluster file access",
        "name": "glusterfs-csi-driver",
        "org.label-schema.schema-version": "= 1.0     org.label-schema.name=CentOS Base Image     org.label-schema.vendor=CentOS     org.label-schema.license=GPLv2     org.label-schema.build-date=20180531",
        "vcs-type": "git",
        "vcs-url": "https://github.com/gluster/gluster-csi-driver",
        "vendor": "gluster.org",
        "version": "(unknown)"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:7dc0dca2b1516961d6b3200564049db0a6e0410b370bb2189e2efae0d368616f",
        "sha256:207a2a561b4feedb244c56d01de2b541772983e55c6fd6c5cc9f13f853dd7ade",
        "sha256:8a27c9866f70d2455c7259a5218ac79e2c6f00b1412a5b71c6ee5c73381591b2"
    ]
}

Additional context
This should be able to be resolved by adding a build hook. See: https://docs.docker.com/docker-cloud/builds/advanced/#custom-build-phase-hooks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions