feat: Enhance argument parsing and configuration management

- Added global argument parser to handle global options and subcommand detection in the CLI.
- Introduced new environment variables for temperature and context window size for AI responses.
- Improved the configuration management script to support additional commands and better error handling.
- Implemented argument parsing for the changelog, document, and message subcommands, allowing for more flexible command usage.
- Enhanced the summary command to work with real Git repositories and added tests for various edge cases.
- Updated tests to cover new functionality and ensure robust error handling across commands.
- Created a new configuration file format to streamline project settings and API configurations.

Author: Test

.giv/config

@@ -6,5 +6,5 @@ GIV_PROJECT_DESCRIPTION="cli tool"
 GIV_PROJECT_URL="giv is a CLI utility for generating changelogs and summaries."
 GIV_API_URL="http://localhost:11434/v1/chat/completions"
 GIV_API_MODEL="devstral"
-GIV_API_KEY="ollama"
 GIV_INITIALIZED="true"
+project.title="Test Value With Spaces"

.giv/config.x

@@ -0,0 +1,10 @@
+project.type="custom"
+project.version_file="src/lib/system.sh"
+project.version_pattern="version[[:space:]]*=[[:space:]]*([0-9]+\.[0-9]+\.[0-9]+)"
+project.title="giv"
+project.description="cli tool"
+project.url="giv is a CLI utility for generating changelogs and summaries."
+api.url="http://localhost:11434/v1/chat/completions"
+api.model="devstral"
+api.key="ollama"
+initialized="true"

src/commands/changelog.sh

@@ -25,6 +25,53 @@ if [ -z "$output_version" ]; then
     output_version=$(get_metadata_value "version" "HEAD" 2>/dev/null || echo "Unreleased")
 fi
 
+# Set defaults for revision and pathspec if not provided
+GIV_REVISION="${GIV_REVISION:---current}"
+GIV_PATHSPEC="${GIV_PATHSPEC:-}"
+export GIV_REVISION
+export GIV_PATHSPEC
+
+# Parse arguments for the changelog subcommand
+parse_changelog_arguments() {
+    while [ "$#" -gt 0 ]; do
+        case "$1" in
+            --revision)
+                shift
+                export GIV_REVISION="$1"
+                ;;
+            --pathspec)
+                shift
+                export GIV_PATHSPEC="$1"
+                ;;
+            --output-file)
+                shift
+                export GIV_OUTPUT_FILE="$1"
+                ;;
+            --output-version)
+                shift
+                export GIV_OUTPUT_VERSION="$1"
+                ;;
+            --*)
+                echo "Error: Unknown option '$1' for changelog subcommand." >&2
+                return 1
+                ;;
+            *)
+                # First non-option argument is the revision
+                if [ -z "${GIV_REVISION_SET:-}" ]; then
+                    export GIV_REVISION="$1"
+                    export GIV_REVISION_SET="true"
+                else
+                    echo "Error: Unknown positional argument '$1' for changelog subcommand." >&2
+                    return 1
+                fi
+                ;;
+        esac
+        shift
+    done
+
+    return 0
+}
+
 # Summarize Git history
 summaries_file=$(portable_mktemp "summaries.XXXXXXX") || {
     printf 'Error: cannot create temp file for summaries\n' >&2

src/commands/config.sh

@@ -44,92 +44,67 @@ quote_value() {
 giv_config() {
     cmd="$1"
     case "$cmd" in
-        --list|list)
+        --list|list|show)
             if [ ! -f "$GIV_CONFIG_FILE" ]; then
                 printf '%s\n' "config file not found" >&2
                 return 1
             fi
-            # Check for malformed lines
-            if [ -s "$GIV_CONFIG_FILE" ]; then
-                # Updated malformed config check to ignore empty lines and lines with only whitespace
-                # Simple validation: check for lines that don't contain = and aren't comments or empty
-                while IFS= read -r line; do
-                    case "$line" in
-                        '#'*|'') continue ;;  # Skip comments and empty lines
-                        *=*) continue ;;      # Valid config line
-                        *)
-                            printf '%s\n' "Malformed config line: $line" >&2
-                            return 1
-                            ;;
-                    esac
-                done < "$GIV_CONFIG_FILE"
+
+            if [ ! -s "$GIV_CONFIG_FILE" ]; then
+                printf '%s\n' "No configuration found." >&2
+                return 0
             fi
-            # Convert GIV_... keys to user keys for output from config file
-            if [ -s "$GIV_CONFIG_FILE" ]; then
-                while IFS= read -r line; do
-                    case "$line" in
-                        GIV_*)
-                            k=${line#GIV_}
-                            k=${k%%=*}
-                            key=$(printf '%s' "$k" | tr 'A-Z_' 'a-z.')
-                            value="${line#*=}"
-                            printf '%s\n' "$key=$value"
-                            ;;
-                        *=*)
-                            printf '%s\n' "$line"
-                            ;;
-                        *)
+
+            # Check for malformed lines
+            while IFS= read -r line; do
+                case "$line" in
+                    '#'*|'') continue ;;  # Skip comments and empty lines
+                    *=*) continue ;;      # Valid config line
+                    *)
+                        printf '%s\n' "Malformed config line: $line" >&2
+                        return 1
                         ;;
-                    esac
-                done < "$GIV_CONFIG_FILE"
-            fi
-            
-            # Also show environment variables with GIV_ prefix that may have been loaded from --config-file
-            for var in $(env | grep '^GIV_'); do
-                case "$var" in
+                esac
+            done < "$GIV_CONFIG_FILE"
+
+            # Convert GIV_... keys to user keys for output from config file
+            while IFS= read -r line; do
+                case "$line" in
                     GIV_*)
-                        k=${var#GIV_}
+                        k=${line#GIV_}
                         k=${k%%=*}
                         key=$(printf '%s' "$k" | tr 'A-Z_' 'a-z.')
-                        value="${var#*=}"
-                        # Only show if not already shown from config file
-                        if [ -z "$(grep "^GIV_$k=" "$GIV_CONFIG_FILE" 2>/dev/null)" ]; then
-                            printf '%s\n' "$key=$value"
-                        fi
+                        value="${line#*=}"
+                        printf '%s\n' "$key=$value"
+                        ;;
+                    *=*)
+                        printf '%s\n' "$line"
                         ;;
                 esac
-            done
+            done < "$GIV_CONFIG_FILE"
             ;;
         --get|get)
             key="$2"
-            # Validate key format
-            env_key="$(normalize_key "$key")"
-            if [ -z "$env_key" ]; then
-                printf '%s\n' "Invalid key format: $key" >&2
-                return 1
-            fi
-            # ENV override
-            if [ -n "$env_key" ]; then
-                eval "env_val=\"\${$env_key-}\""
-                if [ -n "$env_val" ]; then
-                    printf '%s\n' "$env_val"
-                    return 0
-                fi
-            fi
+            # Only support dot-separated keys in the config file
             if [ ! -f "$GIV_CONFIG_FILE" ]; then
                 printf '%s\n' "config file not found" >&2
                 return 1
             fi
-
-            # Try user key first, then GIV_ key
             val=$(grep -E "^$key=" "$GIV_CONFIG_FILE" | cut -d'=' -f2-)
-            if [ -z "$val" ]; then
-                givkey="$(normalize_key "$key")"
-                val=$(grep -E "^$givkey=" "$GIV_CONFIG_FILE" | cut -d'=' -f2-)
-            fi
-            # Remove surrounding quotes if present (both single and double)
             val=$(printf '%s' "$val" | sed -e 's/^"\(.*\)"$/\1/' -e "s/^'\(.*\)'$/\1/")
-            printf '%s\n' "$val"
+            if [ -n "$val" ]; then
+                printf '%s\n' "$val"
+                return 0
+            fi
+            # Fallback to GIV_... env var
+            env_key="$(normalize_key "$key")"
+            env_val="$(printenv "$env_key" 2>/dev/null)"
+            if [ -n "$env_val" ]; then
+                printf '%s\n' "$env_val"
+                return 0
+            fi
+            # Not found
+            return 1
             ;;
         --unset|unset)
             key="$2"
@@ -150,11 +125,8 @@ giv_config() {
                 touch "$GIV_CONFIG_FILE"
             fi
             tmpfile=$(mktemp)
-            givkey="$(normalize_key "$key")"
-            grep -v -E "^($key|$givkey)=" "$GIV_CONFIG_FILE" | grep -v '^$' > "$tmpfile"
-            # Always write in GIV_... format
-            writekey="$(normalize_key "$key")"
-            printf '%s=%s\n' "$writekey" "$(quote_value "$value")" >> "$tmpfile"
+            grep -v -E "^$key=" "$GIV_CONFIG_FILE" | grep -v '^$' > "$tmpfile"
+            printf '%s=%s\n' "$key" "$(quote_value "$value")" >> "$tmpfile"
             mv "$tmpfile" "$GIV_CONFIG_FILE"
             ;;
         -*|help)
@@ -165,51 +137,39 @@ giv_config() {
         *)
             key="$1"
             value="${2:-}"
-            # Validate key format
-            env_key="$(normalize_key "$key")"
-            if [ -z "$env_key" ]; then
-                printf '%s\n' "Invalid key format: $key" >&2
-                return 1
-            fi
             if [ -z "$value" ]; then
-                # ENV override
-                if [ -n "$env_key" ]; then
-                    eval "env_val=\"\${$env_key-}\""
-                    if [ -n "$env_val" ]; then
-                        printf '%s\n' "$env_val"
-                        return 0
-                    fi
-                fi
+                # ENV override fallback for dot-separated keys
                 if [ ! -f "$GIV_CONFIG_FILE" ]; then
                     printf '%s\n' "config file not found" >&2
                     return 1
                 fi
                 if [ -s "$GIV_CONFIG_FILE" ]; then
-                    # Updated malformed config check to ignore empty lines and lines with only whitespace
                     if grep -qvE '^(#|[^=]+=.*|[[:space:]]*)$' "$GIV_CONFIG_FILE"; then
                         printf '%s\n' "Malformed config" >&2
                         return 1
                     fi
                 fi
                 val=$(grep -E "^$key=" "$GIV_CONFIG_FILE" | cut -d'=' -f2-)
-                if [ -z "$val" ]; then
-                    givkey="$(normalize_key "$key")"
-                    val=$(grep -E "^$givkey=" "$GIV_CONFIG_FILE" | cut -d'=' -f2-)
-                fi
-                # Remove surrounding quotes if present (both single and double)
                 val=$(printf '%s' "$val" | sed -e 's/^"\(.*\)"$/\1/' -e "s/^'\(.*\)'$/\1/")
-                printf '%s\n' "$val"
+                if [ -n "$val" ]; then
+                    printf '%s\n' "$val"
+                    return 0
+                fi
+                env_key="$(normalize_key "$key")"
+                env_val="$(printenv "$env_key" 2>/dev/null)"
+                if [ -n "$env_val" ]; then
+                    printf '%s\n' "$env_val"
+                    return 0
+                fi
+                return 1
             else
                 mkdir -p "$GIV_HOME"
                 if [ ! -f "$GIV_CONFIG_FILE" ]; then
                     touch "$GIV_CONFIG_FILE"
                 fi
                 tmpfile=$(mktemp)
-                givkey="$(normalize_key "$key")"
-                grep -v -E "^($key|$givkey)=" "$GIV_CONFIG_FILE" | grep -v '^$' > "$tmpfile"
-                # Always write in GIV_... format
-                writekey="$(normalize_key "$key")"
-                printf '%s=%s\n' "$writekey" "$(quote_value "$value")" >> "$tmpfile"
+                grep -v -E "^$key=" "$GIV_CONFIG_FILE" | grep -v '^$' > "$tmpfile"
+                printf '%s=%s\n' "$key" "$(quote_value "$value")" >> "$tmpfile"
                 mv "$tmpfile" "$GIV_CONFIG_FILE"
             fi
             ;;

src/commands/document.sh

@@ -11,6 +11,53 @@ if [ -n "${GIV_TEST_MOCKS:-}" ] && [ -f "${GIV_TEST_MOCKS:-}" ]; then
   . "$GIV_TEST_MOCKS"
 fi
 
+# Set defaults for revision and pathspec if not provided
+GIV_REVISION="${GIV_REVISION:---current}"
+GIV_PATHSPEC="${GIV_PATHSPEC:-}"
+export GIV_REVISION
+export GIV_PATHSPEC
+
+# Parse arguments for the document subcommand
+parse_document_arguments() {
+    while [ "$#" -gt 0 ]; do
+        case "$1" in
+            --prompt-file)
+                shift
+                export GIV_PROMPT_FILE="$1"
+                ;;
+            --revision)
+                shift
+                export GIV_REVISION="$1"
+                ;;
+            --pathspec)
+                shift
+                export GIV_PATHSPEC="$1"
+                ;;
+            --output-file)
+                shift
+                export GIV_OUTPUT_FILE="$1"
+                ;;
+            *)
+                echo "Error: Unknown option '$1' for document subcommand." >&2
+                return 1
+                ;;
+        esac
+        shift
+    done
+
+    # Set defaults if not provided
+    export GIV_REVISION="${GIV_REVISION:---current}"
+    export GIV_PATHSPEC="${GIV_PATHSPEC:-}"  # Default to empty pathspec
+
+    # Validate required options
+    if [ -z "${GIV_PROMPT_FILE:-}" ]; then
+        echo "Error: --prompt-file is required for the document subcommand." >&2
+        return 1
+    fi
+
+    return 0
+}
+
 # Function to generate documents based on a prompt template
 cmd_document() {
     # Use environment variables set by unified parser
@@ -21,6 +68,13 @@ cmd_document() {
     temp="${GIV_TEMPERATURE:-0.9}"
     ctx="${GIV_CONTEXT_WINDOW:-32768}"
 
+    # Debug: Log environment variables
+    print_debug "GIV_PROMPT_FILE: ${GIV_PROMPT_FILE}"
+    print_debug "GIV_REVISION: ${GIV_REVISION}"
+    print_debug "GIV_PATHSPEC: ${GIV_PATHSPEC}"
+    print_debug "GIV_OUTPUT_FILE: ${GIV_OUTPUT_FILE}"
+    print_debug "GIV_TEMPERATURE: ${GIV_TEMPERATURE}"
+    print_debug "GIV_CONTEXT_WINDOW: ${GIV_CONTEXT_WINDOW}"
 
     # Validate template exists
     if [ ! -f "${prompt_tpl}" ]; then