Don't cache keytar until we know it works (microsoft#148567)

Author: TylerLeonhardt

src/vs/platform/credentials/common/credentialsMainService.ts

@@ -101,7 +101,7 @@ export abstract class BaseCredentialsMainService extends Disposable implements I
 					return;
 				} catch (e) {
 					error = e;
-					this.logService.warn('Error attempting to set a password: ', e);
+					this.logService.warn('Error attempting to set a password: ', e?.message ?? e);
 					attempts++;
 					await new Promise(resolve => setTimeout(resolve, 200));
 				}

src/vs/platform/credentials/electron-main/credentialsMainService.ts

@@ -36,9 +36,10 @@ export class CredentialsNativeMainService extends BaseCredentialsMainService {
 			return this._keytarCache;
 		}
 
-		this._keytarCache = await import('keytar');
+		const keytarCache = await import('keytar');
 		// Try using keytar to see if it throws or not.
-		await this._keytarCache.findCredentials('test-keytar-loads');
+		await keytarCache.findCredentials('test-keytar-loads');
+		this._keytarCache = keytarCache;
 		return this._keytarCache;
 	}