fix(yarn): handle scoped packages in link dependency extraction

Scoped npm packages (e.g., @scope/pkg) have an extra path component
in the tarball structure. The extraction command now uses
--strip-components=4 for scoped packages instead of 3.

Path components:
- Non-scoped: ./node_modules/pkg/ (3 components)
- Scoped: ./node_modules/@scope/pkg/ (4 components)

Co-authored-by: Ona <no-reply@ona.com>

Author: leodido

pkg/leeway/build.go

@@ -1621,8 +1621,14 @@ func (p *Package) buildYarn(buildctx *buildContext, wd, result string) (bld *pac
 							extractCmd = fmt.Sprintf("mkdir -p %s && tar -xzf %s -C %s --strip-components=1 package/", linkDepDir, builtPath, linkDepDir)
 						} else {
 							// YarnApp: extract ./node_modules/<pkg>/* to _link_deps/<pkg>/
-							// --strip-components=3 removes "./node_modules/<pkg>/" prefix
-							extractCmd = fmt.Sprintf("mkdir -p %s && tar -xzf %s -C %s --strip-components=3 ./node_modules/%s/", linkDepDir, builtPath, linkDepDir, npmName)
+							// --strip-components removes "./node_modules/<pkg>/" prefix
+							// For non-scoped packages (e.g., "utils"): 3 components (., node_modules, utils)
+							// For scoped packages (e.g., "@test/utils"): 4 components (., node_modules, @test, utils)
+							stripComponents := 3
+							if strings.HasPrefix(npmName, "@") {
+								stripComponents = 4
+							}
+							extractCmd = fmt.Sprintf("mkdir -p %s && tar -xzf %s -C %s --strip-components=%d ./node_modules/%s/", linkDepDir, builtPath, linkDepDir, stripComponents, npmName)
 						}
 						newRef = fmt.Sprintf("file:./%s", linkDepDir)
 

pkg/leeway/build_internal_test.go

@@ -272,19 +272,23 @@ func TestYarnAppExtraction_ScopedPackage(t *testing.T) {
 				t.Fatalf("failed to create tarball: %v", err)
 			}
 
-			// This is what the CURRENT production code does - always uses strip=3
-			// For scoped packages, this is WRONG and should be strip=4
-			const currentProductionStripComponents = 3
+			// Calculate strip components based on package type:
+			// - Non-scoped packages (e.g., "utils"): 3 components (., node_modules, utils)
+			// - Scoped packages (e.g., "@test/utils"): 4 components (., node_modules, @test, utils)
+			stripComponents := 3
+			if strings.HasPrefix(tt.npmName, "@") {
+				stripComponents = 4
+			}
 
-			// Extract to _link_deps/<npmName>/ using the current production logic
+			// Extract to _link_deps/<npmName>/ using the production logic
 			extractDir := filepath.Join(tmpDir, "_link_deps", tt.npmName)
 			if err := os.MkdirAll(extractDir, 0755); err != nil {
 				t.Fatal(err)
 			}
 
 			tarballFilter := fmt.Sprintf("./node_modules/%s/", tt.npmName)
 			extractCmd := exec.Command("tar", "-xzf", tarballPath, "-C", extractDir,
-				fmt.Sprintf("--strip-components=%d", currentProductionStripComponents), tarballFilter)
+				fmt.Sprintf("--strip-components=%d", stripComponents), tarballFilter)
 			if err := extractCmd.Run(); err != nil {
 				t.Fatalf("extraction failed: %v", err)
 			}