chore: development v0.3.37 - comprehensive testing complete [auto-commit]

Author: githubrobbi

Cargo.toml

@@ -36,7 +36,7 @@ exclude = [
 # Workspace Package Metadata (inherited by all crates)
 # ─────────────────────────────────────────────────────────────────────────────
 [workspace.package]
-version = "0.3.34"
+version = "0.3.37"
 edition = "2024"
 rust-version = "1.85"
 license = "MPL-2.0 OR LicenseRef-UFFS-Commercial"

crates/uffs-cli/src/commands/json_helpers.rs

@@ -65,4 +65,3 @@ pub fn format_json_value(col: &uffs_polars::Column, row_idx: usize) -> String {
         Ok(value) => format_json_string(&value.to_string()),
     }
 }
-

crates/uffs-cli/src/commands/output.rs

@@ -18,10 +18,10 @@ use uffs_core::{export_json, export_table};
 mod streaming;
 #[cfg(windows)]
 pub(crate) use streaming::StreamingWriter;
-#[cfg(windows)]
-pub(crate) use streaming::{format_json_string, format_json_value};
 
-// For tests on non-Windows, we need the JSON helpers too
+// For tests, we need the JSON helpers - on Windows from streaming.rs, elsewhere from json_helpers.rs
+#[cfg(all(test, windows))]
+pub(super) use streaming::format_json_value;
 #[cfg(all(test, not(windows)))]
 #[path = "json_helpers.rs"]
 mod json_helpers;

crates/uffs-cli/src/commands/output_tests.rs

@@ -1,8 +1,8 @@
 //! Tests for output helpers.
 
+use core::time::Duration;
 use std::fs;
 use std::path::PathBuf;
-use core::time::Duration;
 use std::time::{SystemTime, UNIX_EPOCH};
 
 use anyhow::Result;
@@ -463,4 +463,3 @@ fn test_cpp_footer_omits_fast_scan_message_when_elapsed_gt_1s() -> TestResult {
     assert_eq!(lines.get(footer_start + 3), Some(&""));
     Ok(())
 }
-

crates/uffs-cli/src/commands/raw_io.rs

@@ -37,27 +37,25 @@ pub(super) struct NativeOfflineQueryResults {
 }
 
 /// Query filter options for the search command.
-pub(crate) struct QueryFilters<'a> {
+pub struct QueryFilters<'a> {
     /// Parsed search pattern (glob, regex, or literal).
-    pub(crate) parsed: &'a ParsedPattern,
+    pub parsed: &'a ParsedPattern,
     /// Extension filter string (e.g., "pictures,mp4,pdf").
-    pub(crate) ext_filter: Option<&'a str>,
+    pub ext_filter: Option<&'a str>,
     /// Only return files (not directories).
-    pub(crate) files_only: bool,
+    pub files_only: bool,
     /// Only return directories (not files).
-    pub(crate) dirs_only: bool,
+    pub dirs_only: bool,
     /// Hide system files (files starting with $).
-    pub(crate) hide_system: bool,
+    pub hide_system: bool,
     /// Minimum file size filter.
-    pub(crate) min_size: Option<u64>,
+    pub min_size: Option<u64>,
     /// Maximum file size filter.
-    pub(crate) max_size: Option<u64>,
+    pub max_size: Option<u64>,
     /// Maximum number of results to return.
-    pub(crate) limit: u32,
+    pub limit: u32,
 }
 
-
-
 /// Load and filter search data from a raw MFT file (cross-platform debugging).
 ///
 /// This function loads a previously saved raw MFT file and processes it

crates/uffs-cli/src/commands/raw_io_windows.rs

@@ -327,4 +327,3 @@ pub(crate) async fn load_and_filter_data_index_multi(
 
     Ok(final_result)
 }
-

crates/uffs-cli/src/commands/streaming.rs

@@ -108,8 +108,6 @@ impl<W: Write> StreamingWriter<W> {
     }
 
     fn write_json_batch(&self, writer: &mut W, df: &uffs_mft::DataFrame) -> Result<usize> {
-        use std::io::Write as _;
-
         let col_names: Vec<_> = df.get_column_names();
         let columns: Vec<_> = col_names
             .iter()
@@ -229,4 +227,3 @@ pub(crate) fn format_json_value(col: &uffs_polars::Column, row_idx: usize) -> St
         Ok(value) => format_json_string(&value.to_string()),
     }
 }
-

crates/uffs-diag/src/bin/compare_scan_parity.rs

@@ -1,5 +1,8 @@
 //! Comprehensive reference-output vs Rust scan parity comparison tool.
 //!
+//! Exception: Standalone diagnostic CLI binary with complex parity output
+//! formatting. Not library code - splitting would reduce tool readability.
+//!
 //! This tool performs deep comparison of UFFS scan outputs to verify that
 //! the Rust implementation produces identical results to the reference output.
 //!
@@ -69,17 +72,16 @@
 use core::sync::atomic::{AtomicUsize, Ordering};
 use std::collections::{HashMap, HashSet};
 use std::env;
-use std::path::Path;
-
 use std::fs::File;
 use std::io::Write;
+use std::path::Path;
 
 use anyhow::{Context, Result};
 use rayon::prelude::*;
 use uffs_diag::parity::{ComparisonResults, FieldStats};
-use uffs_polars::{CsvReadOptions, DataFrame, SerReader, StringChunked};
 // Wire in crate dependencies for version-locking
 use uffs_mft as _;
+use uffs_polars::{CsvReadOptions, DataFrame, SerReader, StringChunked};
 
 // ============================================================================
 // Column Name Mappings (reference output <-> Rust)
@@ -635,23 +637,44 @@ fn print_results(results: &ComparisonResults) {
     println!("  Rust: {}", results.rust_file);
 
     println!("\n📊 ROW COUNTS");
-    println!("  Reference rows: {:>8}", format_num(results.reference_total_rows));
+    println!(
+        "  Reference rows: {:>8}",
+        format_num(results.reference_total_rows)
+    );
     println!("  Rust rows:  {:>12}", format_num(results.rust_total_rows));
     let diff = results.rust_total_rows as i64 - results.reference_total_rows as i64;
     println!("  Difference: {:>+12}", diff);
 
     println!("\n🔗 PATH MATCHING");
-    println!("  Common paths:    {:>12}", format_num(results.common_paths));
-    println!("  Reference only:  {:>12}", format_num(results.reference_only_paths));
-    println!("  Rust only:       {:>12}", format_num(results.rust_only_paths));
+    println!(
+        "  Common paths:    {:>12}",
+        format_num(results.common_paths)
+    );
+    println!(
+        "  Reference only:  {:>12}",
+        format_num(results.reference_only_paths)
+    );
+    println!(
+        "  Rust only:       {:>12}",
+        format_num(results.rust_only_paths)
+    );
     println!("  Match rate:      {:>11.4}%", results.path_match_rate);
 
     println!("\n📎 ALTERNATE DATA STREAMS (ADS)");
-    println!("  Reference ADS:    {:>10}", format_num(results.reference_ads_count));
-    println!("  Rust ADS entries: {:>10}", format_num(results.rust_ads_count));
+    println!(
+        "  Reference ADS:    {:>10}",
+        format_num(results.reference_ads_count)
+    );
+    println!(
+        "  Rust ADS entries: {:>10}",
+        format_num(results.rust_ads_count)
+    );
 
     println!("\n📈 FIELD-BY-FIELD COMPARISON");
-    println!("{:>20} {:>12} {:>12} {:>10} {:>12}", "Field", "Compared", "Matches", "Rate", "Max Diff");
+    println!(
+        "{:>20} {:>12} {:>12} {:>10} {:>12}",
+        "Field", "Compared", "Matches", "Rate", "Max Diff"
+    );
     println!("{}", "-".repeat(70));
 
     let mut fields: Vec<_> = results.field_stats.keys().collect();
@@ -666,7 +689,11 @@ fn print_results(results: &ComparisonResults) {
                 format_num(stats.total_compared as usize),
                 format_num(stats.exact_matches as usize),
                 stats.match_rate(),
-                if stats.max_abs_diff > 0.0 { format!("{:.0}", stats.max_abs_diff) } else { "-".to_string() }
+                if stats.max_abs_diff > 0.0 {
+                    format!("{:.0}", stats.max_abs_diff)
+                } else {
+                    "-".to_string()
+                }
             );
         }
     }
@@ -714,7 +741,10 @@ fn print_results(results: &ComparisonResults) {
     } else {
         println!("\n⚠️  DIFFERENCES DETECTED:");
         if results.reference_only_paths > 0 {
-            println!("  - {} paths missing from Rust", results.reference_only_paths);
+            println!(
+                "  - {} paths missing from Rust",
+                results.reference_only_paths
+            );
         }
         if results.rust_only_paths > 0 {
             println!("  - {} extra paths in Rust", results.rust_only_paths);
@@ -733,7 +763,11 @@ fn write_markdown_report(results: &ComparisonResults, path: &Path) -> Result<()>
 
     writeln!(f, "# UFFS Scan Parity Report")?;
     writeln!(f)?;
-    writeln!(f, "Generated: {}", chrono::Local::now().format("%Y-%m-%d %H:%M:%S"))?;
+    writeln!(
+        f,
+        "Generated: {}",
+        chrono::Local::now().format("%Y-%m-%d %H:%M:%S")
+    )?;
     writeln!(f)?;
 
     writeln!(f, "## Files Compared")?;
@@ -748,7 +782,11 @@ fn write_markdown_report(results: &ComparisonResults, path: &Path) -> Result<()>
     writeln!(f)?;
     writeln!(f, "| Metric | Count |")?;
     writeln!(f, "|--------|------:|")?;
-    writeln!(f, "| Reference rows | {} |", format_num(results.reference_total_rows))?;
+    writeln!(
+        f,
+        "| Reference rows | {} |",
+        format_num(results.reference_total_rows)
+    )?;
     writeln!(f, "| Rust rows | {} |", format_num(results.rust_total_rows))?;
     let diff = results.rust_total_rows as i64 - results.reference_total_rows as i64;
     writeln!(f, "| Difference | {:+} |", diff)?;
@@ -759,16 +797,28 @@ fn write_markdown_report(results: &ComparisonResults, path: &Path) -> Result<()>
     writeln!(f, "| Metric | Count |")?;
     writeln!(f, "|--------|------:|")?;
     writeln!(f, "| Common paths | {} |", format_num(results.common_paths))?;
-    writeln!(f, "| Reference only | {} |", format_num(results.reference_only_paths))?;
+    writeln!(
+        f,
+        "| Reference only | {} |",
+        format_num(results.reference_only_paths)
+    )?;
     writeln!(f, "| Rust only | {} |", format_num(results.rust_only_paths))?;
-    writeln!(f, "| **Match rate** | **{:.4}%** |", results.path_match_rate)?;
+    writeln!(
+        f,
+        "| **Match rate** | **{:.4}%** |",
+        results.path_match_rate
+    )?;
     writeln!(f)?;
 
     writeln!(f, "## Alternate Data Streams (ADS)")?;
     writeln!(f)?;
     writeln!(f, "| Source | ADS Count |")?;
     writeln!(f, "|--------|----------:|")?;
-    writeln!(f, "| Reference | {} |", format_num(results.reference_ads_count))?;
+    writeln!(
+        f,
+        "| Reference | {} |",
+        format_num(results.reference_ads_count)
+    )?;
     writeln!(f, "| Rust | {} |", format_num(results.rust_ads_count))?;
     writeln!(f)?;
 
@@ -790,7 +840,11 @@ fn write_markdown_report(results: &ComparisonResults, path: &Path) -> Result<()>
                 format_num(stats.total_compared as usize),
                 format_num(stats.exact_matches as usize),
                 stats.match_rate(),
-                if stats.max_abs_diff > 0.0 { format!("{:.0}", stats.max_abs_diff) } else { "-".to_string() }
+                if stats.max_abs_diff > 0.0 {
+                    format!("{:.0}", stats.max_abs_diff)
+                } else {
+                    "-".to_string()
+                }
             )?;
         }
     }
@@ -803,12 +857,19 @@ fn write_markdown_report(results: &ComparisonResults, path: &Path) -> Result<()>
     writeln!(f, "## Summary")?;
     writeln!(f)?;
     if all_match {
-        writeln!(f, "✅ **PERFECT PARITY** - All paths and fields match exactly!")?;
+        writeln!(
+            f,
+            "✅ **PERFECT PARITY** - All paths and fields match exactly!"
+        )?;
     } else {
         writeln!(f, "⚠️ **DIFFERENCES DETECTED**")?;
         writeln!(f)?;
         if results.reference_only_paths > 0 {
-            writeln!(f, "- {} paths missing from Rust", results.reference_only_paths)?;
+            writeln!(
+                f,
+                "- {} paths missing from Rust",
+                results.reference_only_paths
+            )?;
         }
         if results.rust_only_paths > 0 {
             writeln!(f, "- {} extra paths in Rust", results.rust_only_paths)?;

crates/uffs-diag/src/parity/mod.rs

@@ -6,4 +6,3 @@
 mod stats;
 
 pub use stats::{ComparisonResults, FieldStats};
-

crates/uffs-diag/src/parity/stats.rs

@@ -49,7 +49,10 @@ impl FieldStats {
     }
 
     /// Merge another `FieldStats` into this one.
-    #[expect(clippy::float_arithmetic, reason = "statistics require accumulating f64 sums")]
+    #[expect(
+        clippy::float_arithmetic,
+        reason = "statistics require accumulating f64 sums"
+    )]
     pub fn merge(&mut self, other: Self) {
         self.total_compared += other.total_compared;
         self.exact_matches += other.exact_matches;
@@ -97,4 +100,3 @@ pub struct ComparisonResults {
     /// Sample paths only in Rust.
     pub sample_rust_only: Vec<String>,
 }
-