Merge pull request #81 from github/liuliu/fix-index-size-error

liuliu-dev · web-flow · commit 3b0681200fce · 2026-01-13T08:35:17.000-08:00
Fix IndexSizeError when match position exceeds input length
diff --git a/src/text-expander-element.ts b/src/text-expander-element.ts
@@ -103,7 +103,9 @@ class TextExpander {
   }
 
   private positionMenu(menu: HTMLElement, position: number) {
-    const caretRect = new InputRange(this.input, position).getBoundingClientRect()
+    // Clamp position to valid range to avoid IndexSizeError when input text changes
+    const clampedPosition = Math.min(position, this.input.value.length)
+    const caretRect = new InputRange(this.input, clampedPosition).getBoundingClientRect()
     const targetPosition = {left: caretRect.left, top: caretRect.top + caretRect.height}
 
     const currentPosition = menu.getBoundingClientRect()

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,9 @@ class TextExpander {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`private positionMenu(menu: HTMLElement, position: number) {`
`106`		`- const caretRect = new InputRange(this.input, position).getBoundingClientRect()`
	`106`	`+ // Clamp position to valid range to avoid IndexSizeError when input text changes`
	`107`	`+ const clampedPosition = Math.min(position, this.input.value.length)`
	`108`	`+ const caretRect = new InputRange(this.input, clampedPosition).getBoundingClientRect()`
`107`	`109`	`const targetPosition = {left: caretRect.left, top: caretRect.top + caretRect.height}`
`108`	`110`
`109`	`111`	`const currentPosition = menu.getBoundingClientRect()`