Skip to content

Commit ca4f930

Browse files
committed
fix: address PR review feedback
- Gate `mkdir -p $SPECS_DIR` behind DRY_RUN check (bash + PowerShell) so dry-run creates zero directories - Add returncode assertion on `git branch --list` in test - Strengthen spec dir test to verify root `specs/` is not created - Add PowerShell dry-run test class (5 tests, skipped without pwsh) - Fix run_ps_script to use temp repo copy instead of project root Assisted-By: 🤖 Claude Code
1 parent 4378a1e commit ca4f930

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/test_timestamp_branches.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,8 +600,9 @@ def _has_pwsh() -> bool:
600600

601601

602602
def run_ps_script(cwd: Path, *args: str) -> subprocess.CompletedProcess:
603-
"""Run create-new-feature.ps1 with given args."""
604-
cmd = ["pwsh", "-NoProfile", "-File", str(CREATE_FEATURE_PS), *args]
603+
"""Run create-new-feature.ps1 from the temp repo's scripts directory."""
604+
script = cwd / "scripts" / "powershell" / "create-new-feature.ps1"
605+
cmd = ["pwsh", "-NoProfile", "-File", str(script), *args]
605606
return subprocess.run(cmd, cwd=cwd, capture_output=True, text=True)
606607

607608

0 commit comments

Comments
 (0)