fix: address PR review feedback

- Set GIT_TERMINAL_PROMPT=0 for git ls-remote calls to prevent
  credential prompts from blocking dry-run in automation scenarios
- Add returncode assertion to test_dry_run_with_timestamp git
  branch --list check

Assisted-By: 🤖 Claude Code

Author: rhuss

scripts/bash/create-new-feature.sh

@@ -141,7 +141,7 @@ get_highest_from_remote_refs() {
 
     for remote in $(git remote 2>/dev/null); do
         local remote_highest
-        remote_highest=$(git ls-remote --heads "$remote" 2>/dev/null | sed 's|.*refs/heads/||' | _extract_highest_number)
+        remote_highest=$(GIT_TERMINAL_PROMPT=0 git ls-remote --heads "$remote" 2>/dev/null | sed 's|.*refs/heads/||' | _extract_highest_number)
         if [ "$remote_highest" -gt "$highest" ]; then
             highest=$remote_highest
         fi

scripts/powershell/create-new-feature.ps1

@@ -107,7 +107,9 @@ function Get-HighestNumberFromRemoteRefs {
         $remotes = git remote 2>$null
         if ($remotes) {
             foreach ($remote in $remotes) {
+                $env:GIT_TERMINAL_PROMPT = '0'
                 $refs = git ls-remote --heads $remote 2>$null
+                $env:GIT_TERMINAL_PROMPT = $null
                 if ($LASTEXITCODE -eq 0 -and $refs) {
                     $refNames = $refs | ForEach-Object {
                         if ($_ -match 'refs/heads/(.+)$') { $matches[1] }

tests/test_timestamp_branches.py

@@ -606,6 +606,7 @@ def test_dry_run_with_timestamp(self, git_repo: Path):
             capture_output=True,
             text=True,
         )
+        assert branches.returncode == 0, f"'git branch --list' failed: {branches.stderr}"
         assert branches.stdout.strip() == ""
 
     def test_dry_run_with_number(self, git_repo: Path):