fix(kimi): guard symlinked SKILL.md during migration and teardown

Author: meymchen

src/specify_cli/integrations/kimi/__init__.py

@@ -3,9 +3,11 @@
 Kimi uses the ``.kimi-code/skills/speckit-<name>/SKILL.md`` layout with
 ``/skill:speckit-<name>`` invocation syntax.
 
-Includes legacy migration logic for projects initialised before Kimi
-Code CLI adopted the ``.kimi-code/`` directory, as well as for the
-older dotted skill directory naming (``speckit.xxx`` → ``speckit-xxx``).
+Legacy migration covers projects created before Kimi Code CLI moved to
+this layout and handles two distinct changes: the directory move from
+``.kimi/`` to ``.kimi-code/`` (including the ``KIMI.md`` → ``AGENTS.md``
+context file), and the dotted-to-hyphenated skill naming
+(``speckit.xxx`` → ``speckit-xxx``).
 """
 
 from __future__ import annotations
@@ -204,7 +206,10 @@ def _migrate_legacy_kimi_skills_dir(
     for legacy_dir in legacy_dirs:
         if legacy_dir.is_symlink() or not legacy_dir.is_dir():
             continue
-        if not (legacy_dir / "SKILL.md").exists():
+        legacy_skill = legacy_dir / "SKILL.md"
+        # Treat a symlinked SKILL.md as invalid: later read_bytes() would
+        # otherwise follow it and read content from outside the project.
+        if legacy_skill.is_symlink() or not legacy_skill.is_file():
             continue
 
         target_name = _legacy_to_target_name(legacy_dir.name)
@@ -223,9 +228,13 @@ def _migrate_legacy_kimi_skills_dir(
             migrated_count += 1
             continue
 
-        # Target exists — only remove legacy if SKILL.md is identical
+        # Target exists — only remove legacy if SKILL.md is identical.
+        # Skip when the target SKILL.md is a symlink so the byte comparison
+        # never follows it outside the project. (legacy_skill is already
+        # guaranteed to be a real file by the guard above.)
         target_skill = target_dir / "SKILL.md"
-        legacy_skill = legacy_dir / "SKILL.md"
+        if target_skill.is_symlink():
+            continue
         if target_skill.is_file():
             try:
                 if target_skill.read_bytes() == legacy_skill.read_bytes():
@@ -265,7 +274,9 @@ def _is_speckit_generated_skill(skill_dir: Path) -> bool:
     ``SkillsIntegration.setup()`` to avoid deleting user-authored skills.
     """
     skill_file = skill_dir / "SKILL.md"
-    if not skill_file.is_file():
+    # A symlinked SKILL.md is never treated as Speckit-generated, so teardown
+    # cleanup never follows it to read frontmatter from outside the project.
+    if skill_file.is_symlink() or not skill_file.is_file():
         return False
 
     try:

tests/test_presets.py

@@ -3580,7 +3580,7 @@ def test_kimi_legacy_dotted_skill_override_still_applies(self, project_dir, temp
         skills_dir = project_dir / ".kimi-code" / "skills"
         self._create_skill(skills_dir, "speckit.specify", body="untouched")
 
-        (project_dir / ".kimi" / "commands").mkdir(parents=True, exist_ok=True)
+        (project_dir / ".kimi-code" / "commands").mkdir(parents=True, exist_ok=True)
 
         manager = PresetManager(project_dir)
         install_self_test_preset(manager)
@@ -3600,7 +3600,7 @@ def test_kimi_skill_updated_even_when_ai_skills_disabled(self, project_dir, temp
         skills_dir = project_dir / ".kimi-code" / "skills"
         self._create_skill(skills_dir, "speckit-specify", body="untouched")
 
-        (project_dir / ".kimi" / "commands").mkdir(parents=True, exist_ok=True)
+        (project_dir / ".kimi-code" / "commands").mkdir(parents=True, exist_ok=True)
 
         manager = PresetManager(project_dir)
         install_self_test_preset(manager)
@@ -3668,7 +3668,7 @@ def test_kimi_preset_skill_override_resolves_script_placeholders(self, project_d
         self._write_init_options(project_dir, ai="kimi", ai_skills=False, script="sh")
         skills_dir = project_dir / ".kimi-code" / "skills"
         self._create_skill(skills_dir, "speckit-specify", body="untouched")
-        (project_dir / ".kimi" / "commands").mkdir(parents=True, exist_ok=True)
+        (project_dir / ".kimi-code" / "commands").mkdir(parents=True, exist_ok=True)
 
         preset_dir = temp_dir / "kimi-placeholder-override"
         preset_dir.mkdir()