use switch statement for better readability

Author: tommaso-moro

pkg/github/discussions.go

@@ -163,10 +163,13 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 			}
 
 			var discussions []*github.Discussion
-			queries := &discussionQueries{}
+            queries := &discussionQueries{}
 
-			if categoryID != nil {
-				if useOrdering {
+			// we need to check what user inputs we received at runtime, and use the 
+			// most appropriate query 
+            switch {
+				// use query WithCategoryAndOrder
+				case categoryID != nil && useOrdering:
 					log.Printf("GraphQL Query with category and order: %+v", queries.WithCategoryAndOrder)
 					log.Printf("GraphQL Variables: %+v", vars)
 
@@ -177,7 +180,9 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					for _, node := range queries.WithCategoryAndOrder.Repository.Discussions.Nodes {
 						discussions = append(discussions, fragmentToDiscussion(node))
 					}
-				} else {
+
+				// use query WithCategoryNoOrder
+				case categoryID != nil && !useOrdering:
 					log.Printf("GraphQL Query with category no order: %+v", queries.WithCategoryNoOrder)
 					log.Printf("GraphQL Variables: %+v", vars)
 
@@ -188,9 +193,9 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					for _, node := range queries.WithCategoryNoOrder.Repository.Discussions.Nodes {
 						discussions = append(discussions, fragmentToDiscussion(node))
 					}
-				}
-			} else {
-				if useOrdering {
+
+				// use query BasicWithOrder
+				case categoryID == nil && useOrdering:
 					log.Printf("GraphQL Query basic with order: %+v", queries.BasicWithOrder)
 					log.Printf("GraphQL Variables: %+v", vars)
 
@@ -201,7 +206,9 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					for _, node := range queries.BasicWithOrder.Repository.Discussions.Nodes {
 						discussions = append(discussions, fragmentToDiscussion(node))
 					}
-				} else {
+
+				// use query BasicNoOrder
+				case categoryID == nil && !useOrdering:
 					log.Printf("GraphQL Query basic no order: %+v", queries.BasicNoOrder)
 					log.Printf("GraphQL Variables: %+v", vars)
 
@@ -212,8 +219,7 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					for _, node := range queries.BasicNoOrder.Repository.Discussions.Nodes {
 						discussions = append(discussions, fragmentToDiscussion(node))
 					}
-				}
-			}
+            }
 
 			out, err := json.Marshal(discussions)
 			if err != nil {