Skip to content

Commit 3e6d30d

Browse files
committed
Add graphQL error annotations to GitHub pull request functions
1 parent 82c4930 commit 3e6d30d

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pkg/github/pullrequests.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ func CreatePullRequestReview(ctx context.Context, client *githubv4.Client, param
13481348
addPullRequestReviewInput,
13491349
nil,
13501350
); err != nil {
1351-
return utils.NewToolResultError(err.Error()), nil
1351+
return ghErrors.NewGitHubGraphQLErrorResponse(ctx, "failed to create pull request review", err), nil
13521352
}
13531353

13541354
// Return nothing interesting, just indicate success for the time being.
@@ -1516,7 +1516,10 @@ func DeletePendingPullRequestReview(ctx context.Context, client *githubv4.Client
15161516
},
15171517
nil,
15181518
); err != nil {
1519-
return utils.NewToolResultError(err.Error()), nil
1519+
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
1520+
"failed to delete pull request review",
1521+
err,
1522+
), nil
15201523
}
15211524

15221525
// Return nothing interesting, just indicate success for the time being.
@@ -1694,7 +1697,10 @@ func AddCommentToPendingReview(getGQLClient GetGQLClientFn, t translations.Trans
16941697
},
16951698
nil,
16961699
); err != nil {
1697-
return utils.NewToolResultError(err.Error()), nil, nil
1700+
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
1701+
"failed to add comment to pending review",
1702+
err,
1703+
), nil, nil
16981704
}
16991705

17001706
if addPullRequestReviewThreadMutation.AddPullRequestReviewThread.Thread.ID == nil {

0 commit comments

Comments
 (0)