Update params

Author: JoannaaKL

README.md

@@ -762,8 +762,9 @@ The following sets of tools are available (all are on by default):
   - `query`: Filter projects by a search query (matches title and description) (string, optional)
 
 - **update_project_item** - Update project item
+  - `field_id`: The unique identifier of the project field to be updated. (number, required)
+  - `field_value`: The new value for the field: For text, number, and date fields, provide the new value directly. For single select and iteration fields, provide the ID of the option or iteration. To clear the field, set this to null. Example: {"id": 123456, "value": "Done"} (object, required)
   - `item_id`: The unique identifier of the project item. This is not the issue or pull request ID. (number, required)
-  - `new_field`: Object consisting of the ID of the project field to update and the new value for the field. To clear the field, set "value" to null. Example: {"id": 123456, "value": "New Value"} (object, required)
   - `owner`: If owner_type == user it is the handle for the GitHub user account. If owner_type == org it is the name of the organization. The name is not case sensitive. (string, required)
   - `owner_type`: Owner type (string, required)
   - `project_number`: The project's number. (number, required)

pkg/github/__toolsnaps__/update_project_item.snap

@@ -6,15 +6,19 @@
   "description": "Update a specific Project item for a user or org",
   "inputSchema": {
     "properties": {
-      "item_id": {
-        "description": "The unique identifier of the project item. This is not the issue or pull request ID.",
+      "field_id": {
+        "description": "The unique identifier of the project field to be updated.",
         "type": "number"
       },
-      "new_field": {
-        "description": "Object consisting of the ID of the project field to update and the new value for the field. To clear the field, set \"value\" to null. Example: {\"id\": 123456, \"value\": \"New Value\"}",
+      "field_value": {
+        "description": "The new value for the field: For text, number, and date fields, provide the new value directly. For single select and iteration fields, provide the ID of the option or iteration. To clear the field, set this to null. Example: {\"id\": 123456, \"value\": \"Done\"}",
         "properties": {},
         "type": "object"
       },
+      "item_id": {
+        "description": "The unique identifier of the project item. This is not the issue or pull request ID.",
+        "type": "number"
+      },
       "owner": {
         "description": "If owner_type == user it is the handle for the GitHub user account. If owner_type == org it is the name of the organization. The name is not case sensitive.",
         "type": "string"
@@ -37,7 +41,8 @@
       "owner",
       "project_number",
       "item_id",
-      "new_field"
+      "field_id",
+      "field_value"
     ],
     "type": "object"
   },

pkg/github/projects.go

@@ -691,9 +691,13 @@ func UpdateProjectItem(getClient GetClientFn, t translations.TranslationHelperFu
 				mcp.Required(),
 				mcp.Description("The unique identifier of the project item. This is not the issue or pull request ID."),
 			),
-			mcp.WithObject("new_field",
+			mcp.WithNumber("field_id",
+				mcp.Required(),
+				mcp.Description("The unique identifier of the project field to be updated."),
+			),
+			mcp.WithObject("field_value",
 				mcp.Required(),
-				mcp.Description("Object consisting of the ID of the project field to update and the new value for the field. To clear the field, set \"value\" to null. Example: {\"id\": 123456, \"value\": \"New Value\"}"),
+				mcp.Description("The new value for the field: For text, number, and date fields, provide the new value directly. For single select and iteration fields, provide the ID of the option or iteration. To clear the field, set this to null. Example: {\"id\": 123456, \"value\": \"Done\"}"),
 			),
 		), func(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
 			owner, err := RequiredParam[string](req, "owner")
@@ -713,21 +717,28 @@ func UpdateProjectItem(getClient GetClientFn, t translations.TranslationHelperFu
 				return mcp.NewToolResultError(err.Error()), nil
 			}
 
-			rawNewField, exists := req.GetArguments()["new_field"]
+			fieldID, err := RequiredInt(req, "field_id")
+			if err != nil {
+				return mcp.NewToolResultError(err.Error()), nil
+			}
+
+			rawFieldValue, exists := req.GetArguments()["field_value"]
 			if !exists {
-				return mcp.NewToolResultError("missing required parameter: new_field"), nil
+				return mcp.NewToolResultError("missing required parameter: field_value"), nil
 			}
 
-			newField, ok := rawNewField.(map[string]any)
-			if !ok || newField == nil {
-				return mcp.NewToolResultError("new_field must be an object"), nil
+			fieldValue, ok := rawFieldValue.(map[string]any)
+			if !ok || fieldValue == nil {
+				return mcp.NewToolResultError("field_value must be an object"), nil
 			}
 
-			updatePayload, err := buildUpdateProjectItem(newField)
-			if err != nil {
-				return mcp.NewToolResultError(err.Error()), nil
+			valueField, ok := fieldValue["value"]
+			if !ok {
+				return nil, fmt.Errorf("field_value is required")
 			}
 
+			updatePayload := &updateProjectItem{ID: fieldID, Value: valueField}
+
 			client, err := getClient(ctx)
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
@@ -913,29 +924,29 @@ type listProjectsOptions struct {
 	Query string `url:"q,omitempty"`
 }
 
-func buildUpdateProjectItem(input map[string]any) (*updateProjectItem, error) {
-	if input == nil {
-		return nil, fmt.Errorf("new_field must be an object")
-	}
-
-	idField, ok := input["id"]
-	if !ok {
-		return nil, fmt.Errorf("new_field.id is required")
-	}
-
-	idFieldAsFloat64, ok := idField.(float64) // JSON numbers are float64
-	if !ok {
-		return nil, fmt.Errorf("new_field.id must be a number")
-	}
-
-	valueField, ok := input["value"]
-	if !ok {
-		return nil, fmt.Errorf("new_field.value is required")
-	}
-	payload := &updateProjectItem{ID: int(idFieldAsFloat64), Value: valueField}
-
-	return payload, nil
-}
+// func buildUpdateProjectItem(input map[string]any) (*updateProjectItem, error) {
+// 	if input == nil {
+// 		return nil, fmt.Errorf("new_field must be an object")
+// 	}
+
+// 	idField, ok := input["id"]
+// 	if !ok {
+// 		return nil, fmt.Errorf("new_field.id is required")
+// 	}
+
+// 	idFieldAsFloat64, ok := idField.(float64) // JSON numbers are float64
+// 	if !ok {
+// 		return nil, fmt.Errorf("new_field.id must be a number")
+// 	}
+
+// 	valueField, ok := input["value"]
+// 	if !ok {
+// 		return nil, fmt.Errorf("new_field.value is required")
+// 	}
+// 	payload := &updateProjectItem{ID: int(idFieldAsFloat64), Value: valueField}
+
+// 	return payload, nil
+// }
 
 // addOptions adds the parameters in opts as URL query parameters to s. opts
 // must be a struct whose fields may contain "url" tags.

pkg/github/projects_test.go

@@ -1175,8 +1175,9 @@ func Test_UpdateProjectItem(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.Properties, "owner")
 	assert.Contains(t, tool.InputSchema.Properties, "project_number")
 	assert.Contains(t, tool.InputSchema.Properties, "item_id")
-	assert.Contains(t, tool.InputSchema.Properties, "new_field")
-	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner_type", "owner", "project_number", "item_id", "new_field"})
+	assert.Contains(t, tool.InputSchema.Properties, "field_id")
+	assert.Contains(t, tool.InputSchema.Properties, "field_value")
+	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner_type", "owner", "project_number", "item_id", "field_id", "field_value"})
 
 	orgUpdatedItem := map[string]any{
 		"id":           801,
@@ -1223,8 +1224,8 @@ func Test_UpdateProjectItem(t *testing.T) {
 				"owner_type":     "org",
 				"project_number": float64(1001),
 				"item_id":        float64(5555),
-				"new_field": map[string]any{
-					"id":    float64(101),
+				"field_id":       float64(101),
+				"field_value": map[string]any{
 					"value": "Done",
 				},
 			},