Skip to content

Commit 18f54e8

Browse files
Update e2e tests to use GITHUB_ACCESS_TOKEN
- Update e2e tests to use new GITHUB_ACCESS_TOKEN variable - Update e2e README documentation Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
1 parent 3caf1ca commit 18f54e8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

e2e.test

397 KB
Binary file not shown.

e2e/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Since these tests require a token to interact with real resources on the GitHub
1616
GITHUB_MCP_SERVER_E2E_TOKEN=<YOUR TOKEN> go test -v --tags e2e ./e2e
1717
```
1818

19-
The `GITHUB_MCP_SERVER_E2E_TOKEN` environment variable is mapped to `GITHUB_PERSONAL_ACCESS_TOKEN` internally, but separated to avoid accidental reuse of credentials.
19+
The `GITHUB_MCP_SERVER_E2E_TOKEN` environment variable is mapped to `GITHUB_ACCESS_TOKEN` internally, but separated to avoid accidental reuse of credentials.
2020

2121
## Example
2222

e2e/e2e_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ func setupMCPClient(t *testing.T, options ...clientOption) *mcp.ClientSession {
174174
"-i",
175175
"--rm",
176176
"-e",
177-
"GITHUB_PERSONAL_ACCESS_TOKEN", // Personal access token is all required
177+
"GITHUB_ACCESS_TOKEN", // GitHub access token (PAT or OAuth)
178178
}
179179

180180
host := getE2EHost()
@@ -193,7 +193,7 @@ func setupMCPClient(t *testing.T, options ...clientOption) *mcp.ClientSession {
193193
// Construct the env vars for the MCP Client to execute docker with
194194
// We need to include os.Environ() so docker can find its socket and config
195195
dockerEnvVars := append(os.Environ(),
196-
fmt.Sprintf("GITHUB_PERSONAL_ACCESS_TOKEN=%s", token),
196+
fmt.Sprintf("GITHUB_ACCESS_TOKEN=%s", token),
197197
fmt.Sprintf("GITHUB_TOOLSETS=%s", strings.Join(opts.enabledToolsets, ",")),
198198
)
199199

0 commit comments

Comments
 (0)