Address code review feedback - allow all window events consistently

- Simplified logic to allow all window-level events (not just resize)
- This provides consistent behavior: window events = viewport detection (allowed)
- document/element events = element observation (suggest observers)
- Added test for window.scroll to verify consistent behavior

Co-authored-by: mattcosta7 <8616962+mattcosta7@users.noreply.github.com>

Author: Copilot

lib/rules/prefer-observers.js

@@ -63,9 +63,10 @@ export default {
         if (name.type !== 'Literal') return
         if (!(name.value in observerMap)) return
 
-        // Allow window.addEventListener("resize", ...) and window.addEventListener("orientationchange", ...)
+        // Allow window events (window.resize for viewport detection)
+        // Note: orientationchange is not in observerMap but this check is defensive
         if (node.callee.object && isWindowObject(node.callee.object)) {
-          if (name.value === 'resize') return
+          return
         }
 
         context.report({

tests/prefer-observers.js

@@ -16,6 +16,10 @@ ruleTester.run('prefer-observers', rule, {
     {
       code: 'window.addEventListener("orientationchange", function(event) {})',
     },
+    // window.scroll is also valid - window events are for viewport-level detection
+    {
+      code: 'window.addEventListener("scroll", function(event) {})',
+    },
     // ResizeObserver on regular elements is valid
     {
       code: 'const observer = new ResizeObserver(() => {}); observer.observe(someElement)',