Skip to content

Commit d448a4d

Browse files
Merge branch 'main' into patch-1
2 parents fc12651 + c310656 commit d448a4d

File tree

119 files changed

+23991
-3063
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+23991
-3063
lines changed
-34.8 KB
Binary file not shown.
-24.1 KB
Binary file not shown.
309 KB
Loading
284 KB
Loading

config/kubernetes/default/deployments/webapp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ kind: Deployment
33
metadata:
44
name: webapp
55
spec:
6-
replicas: 2
6+
replicas: 1
77
selector:
88
matchLabels:
99
app: webapp

config/kubernetes/production/deployments/webapp.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ kind: Deployment
33
metadata:
44
name: webapp
55
spec:
6-
replicas: 4
6+
replicas: 6
77
selector:
88
matchLabels:
99
app: webapp
@@ -23,12 +23,12 @@ spec:
2323
image: docs-internal
2424
resources:
2525
requests:
26-
cpu: 4000m
26+
cpu: 2500m
2727
# Absolute minimum to start app is 1000m
2828
# Node is single-threaded but we want more CPUs
2929
# for OS and image resizing, and other binary executions
3030
# Better to increase replicas or memory than CPU
31-
memory: 8Gi
31+
memory: 6.0Gi
3232
# Absolute minimum to start app is 4500Mi
3333
# Would increase with more pages, versions, or languages supported
3434
# The additional memory helps during traffic surges

content/actions/how-tos/secure-your-work/use-artifact-attestations/enforce-artifact-attestations.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ To set up an admission controller for enforcing GitHub artifact attestations, yo
2323

2424
### Deploy the Sigstore Policy Controller
2525

26-
We have packaged the Sigstore Policy Controller as a [GitHub distributed Helm chart](https://github.com/github/artifact-attestations-helm-charts). Before you begin, ensure you have the following prerequisites:
26+
The Sigstore Policy Controller has been packaged and made available via a [Helm chart](https://github.com/sigstore/helm-charts). Before you begin, ensure you have the following prerequisites:
2727

2828
* A Kubernetes cluster with version 1.27 or later
2929
* [Helm](https://helm.sh/docs/intro/install/) 3.0 or later
@@ -34,8 +34,8 @@ First, install the Helm chart that deploys the Sigstore Policy Controller:
3434
```bash copy
3535
helm upgrade policy-controller --install --atomic \
3636
--create-namespace --namespace artifact-attestations \
37-
oci://ghcr.io/github/artifact-attestations-helm-charts/policy-controller \
38-
--version v0.12.0-github12
37+
oci://ghcr.io/sigstore/helm-charts/policy-controller \
38+
--version 0.10.5
3939
```
4040

4141
This installs the Policy Controller into the `artifact-attestations` namespace. At this point, no policies have been configured, and it will not enforce any attestations.
@@ -48,7 +48,7 @@ Once the policy controller has been deployed, you need to add the GitHub `TrustR
4848
helm upgrade trust-policies --install --atomic \
4949
--namespace artifact-attestations \
5050
oci://ghcr.io/github/artifact-attestations-helm-charts/trust-policies \
51-
--version v0.6.2 \
51+
--version v0.7.0 \
5252
--set policy.enabled=true \
5353
--set policy.organization=MY-ORGANIZATION
5454
```
@@ -86,7 +86,7 @@ For example, to enforce attestations for images that match the pattern `ghcr.io/
8686
helm upgrade trust-policies --install --atomic \
8787
--namespace artifact-attestations \
8888
oci://ghcr.io/github/artifact-attestations-helm-charts/trust-policies \
89-
--version v0.6.2 \
89+
--version v0.7.0 \
9090
--set policy.enabled=true \
9191
--set policy.organization=MY-ORGANIZATION \
9292
--set-json 'policy.exemptImages=["index.docker.io/library/busybox**"]' \
@@ -119,13 +119,13 @@ To see the full set of options you may configure with the Helm chart, you can ru
119119
For policy controller options:
120120

121121
```bash copy
122-
helm show values oci://ghcr.io/github/artifact-attestations-helm-charts/policy-controller --version v0.12.0-github12
122+
helm show values oci://ghcr.io/sigstore/helm-charts/policy-controller --version 0.10.5
123123
```
124124

125125
For trust policy options:
126126

127127
```bash copy
128-
helm show values oci://ghcr.io/github/artifact-attestations-helm-charts/trust-policies --version v0.6.2
128+
helm show values oci://ghcr.io/github/artifact-attestations-helm-charts/trust-policies --version v0.7.0
129129
```
130130

131131
For more information on the Sigstore Policy Controller, see the [Sigstore Policy Controller documentation](https://docs.sigstore.dev/policy-controller/overview/).

content/actions/reference/security/secure-use.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,30 @@ For more information, see [AUTOTITLE](/code-security/code-scanning/introduction-
105105

106106
To help mitigate the risk of an exposed token, consider restricting the assigned permissions. For more information, see [AUTOTITLE](/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token).
107107

108-
### Using third-party actions
108+
{% ifversion custom-org-roles %}
109+
110+
## Mitigating the risks of untrusted code checkout
111+
112+
Similar to script injection attacks, untrusted pull request content that automatically triggers actions processing can also pose a security risk. The `pull_request_target` and `workflow_run` workflow triggers, when used with the checkout of an untrusted pull request, expose the repository to security compromises. These workflows are privileged, which means they share the same cache of the main branch with other privileged workflow triggers, and may have repository write access and access to referenced secrets. These vulnerabilities can be exploited to take over a repository.
113+
114+
For more information on these triggers, how to use them, and the associated risks, see [AUTOTITLE](/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target) and [AUTOTITLE](/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run).
115+
116+
For additional examples and guidance on the risks of untrusted code checkout, see [Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) from {% data variables.product.prodname_security %} and the [Dangerous-Workflow](https://github.com/ossf/scorecard/blob/main/docs/checks.md#dangerous-workflow) documentation from OpenSSF Scorecard.
117+
118+
### Good practices
119+
120+
121+
* Avoid using the `pull_request_target` workflow trigger if it's not necessary. For privilege separation between workflows, `workflow_run` is a better trigger. Only use these workflow triggers when the workflow actually needs the privileged context.
122+
123+
* Avoid using the `pull_request_target` and `workflow_run` workflow triggers with untrusted pull requests or code content. Workflows that use these triggers must not explicitly check out untrusted code, including from pull request forks or from repositories that are not under your control. Workflows triggered on `workflow_run` should treat artifacts uploaded from other workflows with caution.
124+
125+
* {% data variables.product.prodname_codeql %} can scan and detect potentially vulnerable {% data variables.product.prodname_actions %} workflows. You can configure default setup for the repository, and ensure that {% data variables.product.prodname_actions %} scanning is enabled. For more information, see [AUTOTITLE](/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning).
126+
127+
* OpenSSF Scorecards can help you identify potentially vulnerable workflows, along with other security risks when using {% data variables.product.prodname_actions %}. See [Using OpenSSF Scorecards to secure workflow dependencies](#using-openssf-scorecards-to-secure-workflow-dependencies) later in this article.
128+
129+
{% endif %}
130+
131+
## Using third-party actions
109132

110133
The individual jobs in a workflow can interact with (and compromise) other jobs. For example, a job querying the environment variables used by a later job, writing files to a shared directory that a later job processes, or even more directly by interacting with the Docker socket and inspecting other running containers and executing commands in them.
111134

content/actions/reference/workflows-and-actions/events-that-trigger-workflows.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,6 +1159,8 @@ For more information, see the {% data variables.product.prodname_cli %} informat
11591159

11601160
This event occurs when a workflow run is requested or completed. It allows you to execute a workflow based on execution or completion of another workflow. The workflow started by the `workflow_run` event is able to access secrets and write tokens, even if the previous workflow was not. This is useful in cases where the previous workflow is intentionally not privileged, but you need to take a privileged action in a later workflow.
11611161

1162+
{% data reusables.actions.workflow-run-permissions-warning %}
1163+
11621164
In this example, a workflow is configured to run after the separate "Run Tests" workflow completes.
11631165

11641166
```yaml

content/code-security/code-scanning/managing-code-scanning-alerts/assessing-code-scanning-alerts-for-your-repository.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ By default, the {% data variables.product.prodname_code_scanning %} alerts page
3737
![Screenshot of a {% data variables.product.prodname_code_scanning %} alert. The "Show paths" and "Show more" links are outlined in dark orange.](/assets/images/help/repository/code-scanning-alert-details.png)
3838

3939
1. Alerts from {% data variables.product.prodname_codeql %} analysis include a description of the problem. Click **Show more** for guidance on how to fix your code.
40+
{% data reusables.security.alert-assignee-step %}
4041

4142
For more information, see [AUTOTITLE](/code-security/code-scanning/managing-code-scanning-alerts/about-code-scanning-alerts).
4243

0 commit comments

Comments
 (0)