CI and test fixes (#3)

* Fix Node test startup on Windows

* Fix Go tests

* Fix Python tests

* Remove Python egg-info dir which shouldn't be tracked in Git

* Publish packages only from main

* Fix formatting

* Add Windows CI job. Simplify Python CI matrix to just 3.12 (latest documented supported version)

* Avoid duplicate CI jobs (push and pull_request)

* Avoid line endings issues in CI

* Clean up defaults

* Similarly don't run go fmt on Windows due to line endings differences

* Fix Python tests in Windows CI job

Author: SteveSandersonMS

.github/workflows/publish.yml

@@ -1,6 +1,8 @@
 name: Publish package to GitHub Packages
 on:
   push:
+    branches:
+      - main
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/sdk-e2e-tests.yml

@@ -2,30 +2,29 @@ name: "SDK E2E Tests"
 
 env:
   HUSKY: 0
+  PYTHONUTF8: 1
 
 on:
   push:
+    branches: [main]
   pull_request:
   workflow_dispatch:
   merge_group:
 
 permissions:
   contents: read
 
-defaults:
-  run:
-    shell: bash
-
 jobs:
   nodejs-sdk:
     name: "Node.js SDK Tests"
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     defaults:
       run:
+        shell: bash
         working-directory: ./nodejs
     steps:
       - uses: actions/checkout@v6
@@ -38,6 +37,7 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Run prettier check
+        if: runner.os == 'Linux'
         run: npm run format:check
 
       - name: Run ESLint
@@ -57,10 +57,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     defaults:
       run:
+        shell: bash
         working-directory: ./go
     steps:
       - uses: actions/checkout@v6
@@ -70,6 +71,7 @@ jobs:
           go-version: "1.21"
 
       - name: Run go fmt
+        if: runner.os == 'Linux'
         working-directory: ./go
         run: |
           go fmt ./...
@@ -81,6 +83,7 @@ jobs:
           echo "✅ go fmt produced no changes"
 
       - name: Install golangci-lint
+        if: runner.os == 'Linux'
         uses: golangci/golangci-lint-action@v9
         with:
           working-directory: ./go
@@ -98,18 +101,18 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest]
-        python-version: ["3.9", "3.10", "3.11"]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     defaults:
       run:
+        shell: bash
         working-directory: ./python
     steps:
       - uses: actions/checkout@v6
       - uses: ./.github/actions/setup-copilot
       - uses: actions/setup-python@v6
         with:
-          python-version: ${{ matrix.python-version }}
+          python-version: "3.12"
 
       - name: Set up uv
         uses: astral-sh/setup-uv@v7

go/client.go

@@ -9,6 +9,7 @@ import (
 	"os/exec"
 	"regexp"
 	"strconv"
+	"strings"
 	"sync"
 	"time"
 
@@ -346,7 +347,15 @@ func (c *Client) startCLIServer() error {
 		args = append(args, "--port", strconv.Itoa(c.options.Port))
 	}
 
-	c.process = exec.Command(c.options.CLIPath, args...)
+	// If CLIPath is a .js file, run it with node
+	// Note we can't rely on the shebang as Windows doesn't support it
+	command := c.options.CLIPath
+	if strings.HasSuffix(c.options.CLIPath, ".js") {
+		command = "node"
+		args = append([]string{c.options.CLIPath}, args...)
+	}
+
+	c.process = exec.Command(command, args...)
 
 	// Set working directory if specified
 	if c.options.Cwd != "" {

go/client_test.go

@@ -240,18 +240,10 @@ func TestClient(t *testing.T) {
 
 // Helper function to find CLI path
 func findCLIPath() string {
-	// Try relative path from SDK location
-	possiblePaths := []string{
-		"../../dist-cli/index.js",
-		"../../../dist-cli/index.js",
-		"./dist-cli/index.js",
-	}
-
-	for _, p := range possiblePaths {
-		abs, _ := filepath.Abs(p)
-		if fileExists(abs) {
-			return abs
-		}
+	// Look for CLI in sibling nodejs directory's node_modules
+	abs, _ := filepath.Abs("../nodejs/node_modules/@github/copilot/index.js")
+	if fileExists(abs) {
+		return abs
 	}
 
 	return ""

nodejs/.prettierrc.json

@@ -5,5 +5,6 @@
   "printWidth": 100,
   "tabWidth": 4,
   "useTabs": false,
-  "arrowParens": "always"
+  "arrowParens": "always",
+  "endOfLine": "lf"
 }

nodejs/src/client.ts

@@ -429,7 +429,13 @@ export class CopilotClient {
             const envWithoutNodeDebug = { ...this.options.env };
             delete envWithoutNodeDebug.NODE_DEBUG;
 
-            this.cliProcess = spawn(this.options.cliPath, args, {
+            // If cliPath is a .js file, spawn it with node
+            // Note that we can't rely on the shebang as Windows doesn't support it
+            const isJsFile = this.options.cliPath.endsWith(".js");
+            const command = isJsFile ? "node" : this.options.cliPath;
+            const spawnArgs = isJsFile ? [this.options.cliPath, ...args] : args;
+
+            this.cliProcess = spawn(command, spawnArgs, {
                 stdio: this.options.useStdio
                     ? ["pipe", "pipe", "pipe"]
                     : ["ignore", "pipe", "pipe"],

nodejs/src/query.ts

@@ -167,13 +167,19 @@ export async function* query(options: QueryOptions): AsyncGenerator<SessionEvent
             const systemMessageConfig = systemMessage
                 ? ({ mode: "replace", content: systemMessage } satisfies SystemMessageConfig)
                 : undefined;
-            session = await client.createSession({ model, tools, systemMessage: systemMessageConfig });
+            session = await client.createSession({
+                model,
+                tools,
+                systemMessage: systemMessageConfig,
+            });
         }
 
         // Use EventEmitter to convert session events to async iterator
         const eventEmitter = new EventEmitter<{ data: [SessionEvent] }>();
         session.on((event) => eventEmitter.emit("data", event));
-        const eventIterator = on(eventEmitter, "data", { signal: abortController.signal }) as SessionEventIterator;
+        const eventIterator = on(eventEmitter, "data", {
+            signal: abortController.signal,
+        }) as SessionEventIterator;
 
         session.send({ prompt, attachments }).catch((sendError) => {
             !turnFinished && eventIterator.throw!(sendError);
@@ -195,7 +201,7 @@ export async function* query(options: QueryOptions): AsyncGenerator<SessionEvent
                 throw new Error(
                     typeof event.data === "object" && event.data && "message" in event.data
                         ? String(event.data.message)
-                        : "Unknown error",
+                        : "Unknown error"
                 );
             }
 

nodejs/test/client.test.ts

@@ -4,22 +4,14 @@
  * Tests the CopilotClient class - the main SDK entry point
  */
 
-import fs from "fs";
 import path from "path";
 import { fileURLToPath } from "url";
 import { afterEach, describe, expect, it } from "vitest";
 import { CopilotClient, SystemMessageConfig } from "../src/index.js";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
-const CLI_PATH = path.resolve(__dirname, "../../../dist-cli/index.js");
-
-// Verify CLI exists before running tests
-if (!fs.existsSync(CLI_PATH)) {
-    throw new Error(
-        `CLI not found at ${CLI_PATH}. Run 'npm run build' in the root directory first.`
-    );
-}
+const CLI_PATH = path.resolve(__dirname, "../node_modules/@github/copilot/index.js");
 
 describe("CopilotClient", () => {
     let client: CopilotClient | null = null;

python/copilot/client.py

@@ -233,7 +233,15 @@ async def ping(self, message: Optional[str] = None) -> dict:
 
     async def _start_cli_server(self) -> None:
         """Start the CLI server process"""
-        args = [self.options["cli_path"], "--server", "--log-level", self.options["log_level"]]
+        cli_path = self.options["cli_path"]
+        args = ["--server", "--log-level", self.options["log_level"]]
+
+        # If cli_path is a .js file, run it with node
+        # Note that we can't rely on the shebang as Windows doesn't support it
+        if cli_path.endswith(".js"):
+            args = ["node", cli_path] + args
+        else:
+            args = [cli_path] + args
 
         # Choose transport mode
         if self.options["use_stdio"]: