Create Call library

Author: lcartey

cpp/common/src/codingstandards/cpp/Call.qll

@@ -0,0 +1,18 @@
+import cpp
+import codingstandards.cpp.types.Type
+
+/**
+ * Gets the `FunctionType` of an expression call.
+ */
+FunctionType getExprCallFunctionType(ExprCall call) {
+  // A standard expression call
+  // Returns a FunctionPointerIshType
+  result = call.(ExprCall).getExpr().getType()
+  or
+  // An expression call using the pointer to member operator (.* or ->*)
+  // This special handling is required because we don't have a CodeQL class representing the call
+  // to a pointer to member function, but the right hand side is extracted as the -1 child of the
+  // call.
+  // Returns a RoutineType
+  result = call.(ExprCall).getChild(-1).getType().(PointerToMemberType).getBaseType()
+}

cpp/misra/src/codingstandards/cpp/misra/BuiltInTypeRules.qll

@@ -4,6 +4,7 @@
 
 import cpp
 import codingstandards.cpp.misra
+import codingstandards.cpp.Call
 import codingstandards.cpp.Type
 
 /**
@@ -120,19 +121,6 @@ class CanonicalIntegerTypes extends NumericType, IntegralType {
   CanonicalIntegerTypes() { this = this.getCanonicalArithmeticType() }
 }
 
-FunctionType getExprCallFunctionType(ExprCall call) {
-  // A standard expression call
-  // Returns a FunctionPointerIshType
-  result = call.(ExprCall).getExpr().getType()
-  or
-  // An expression call using the pointer to member operator (.* or ->*)
-  // This special handling is required because we don't have a CodeQL class representing the call
-  // to a pointer to member function, but the right hand side is extracted as the -1 child of the
-  // call.
-  // Returns a RoutineType
-  result = call.(ExprCall).getChild(-1).getType().(PointerToMemberType).getBaseType()
-}
-
 predicate isAssignment(Expr source, NumericType targetType, string context) {
   exists(Expr preConversionAssignment |
     isPreConversionAssignment(preConversionAssignment, targetType, context) and