Making Repository a parameter for DetachHandlers

StanleyGoldman · StanleyGoldman · commit f99cf4634af6 · 2017-10-27T18:11:15.000-04:00
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs
@@ -47,7 +47,7 @@ public override void OnEnable()
         public override void OnDisable()
         {
             base.OnDisable();
-            DetachHandlers();
+            DetachHandlers(Repository);
         }
 
         private void AttachHandlers(IRepository repository)
@@ -57,11 +57,11 @@ private void AttachHandlers(IRepository repository)
             repository.OnStatusChanged += RunStatusUpdateOnMainThread;
         }
 
-        private void DetachHandlers()
+        private void DetachHandlers(IRepository oldRepository)
         {
-            if (Repository == null)
+            if (oldRepository == null)
                 return;
-            Repository.OnStatusChanged -= RunStatusUpdateOnMainThread;
+            oldRepository.OnStatusChanged -= RunStatusUpdateOnMainThread;
         }
 
         private void RunStatusUpdateOnMainThread(GitStatus status)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public override void OnEnable()`
`47`	`47`	`public override void OnDisable()`
`48`	`48`	`{`
`49`	`49`	`base.OnDisable();`
`50`		`- DetachHandlers();`
	`50`	`+ DetachHandlers(Repository);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`private void AttachHandlers(IRepository repository)`
`@@ -57,11 +57,11 @@ private void AttachHandlers(IRepository repository)`
`57`	`57`	`repository.OnStatusChanged += RunStatusUpdateOnMainThread;`
`58`	`58`	`}`
`59`	`59`
`60`		`- private void DetachHandlers()`
	`60`	`+ private void DetachHandlers(IRepository oldRepository)`
`61`	`61`	`{`
`62`		`- if (Repository == null)`
	`62`	`+ if (oldRepository == null)`
`63`	`63`	`return;`
`64`		`- Repository.OnStatusChanged -= RunStatusUpdateOnMainThread;`
	`64`	`+ oldRepository.OnStatusChanged -= RunStatusUpdateOnMainThread;`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`private void RunStatusUpdateOnMainThread(GitStatus status)`