Merge pull request #531 from github-for-unity/fixes/cache-invalidation-loop

Preventing cache invalidation loop

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -133,7 +133,7 @@ protected ManagedCacheBase(bool invalidOnFirstRun)
         public void ValidateData()
         {
             var initialized = ValidateInitialized();
-            if (!initialized)
+            if (initialized)
             {
                 if (DateTimeOffset.Now - LastUpdatedAt > DataTimeout)
                 {
@@ -145,8 +145,8 @@ public void ValidateData()
 
         private bool ValidateInitialized()
         {
-            var notInitialized = ApplicationCache.Instance.FirstRunAt > InitializedAt;
-            if (notInitialized)
+            var isInitialized = IsInitialized;
+            if (!isInitialized)
             {
                 Logger.Trace("Not Initialized");
 
@@ -156,7 +156,7 @@ private bool ValidateInitialized()
                 }
             }
 
-            return notInitialized;
+            return isInitialized;
         }
 
         public void InvalidateData()
@@ -167,7 +167,7 @@ public void InvalidateData()
 
         protected void SaveData(DateTimeOffset now, bool isUpdated)
         {
-            if (InitializedAt == DateTimeOffset.MinValue)
+            if (!IsInitialized)
             {
                 InitializedAt = now;
             }
@@ -196,6 +196,11 @@ protected void SaveData(DateTimeOffset now, bool isUpdated)
         public abstract string LastVerifiedAtString { get; protected set; }
         public abstract string InitializedAtString { get; protected set; }
 
+        public bool IsInitialized
+        {
+            get { return ApplicationCache.Instance.FirstRunAt <= InitializedAt; }
+        }
+
         public DateTimeOffset LastUpdatedAt
         {
             get