Merge pull request #166 from github-for-unity/fixes/disposable-task-manager

Disposable ITaskManager

Author: shana

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -211,7 +211,7 @@ protected virtual void Dispose(bool disposing)
             {
                 if (disposed) return;
                 disposed = true;
-                if (TaskManager != null) TaskManager.Stop();
+                if (TaskManager != null) TaskManager.Dispose();
                 if (repositoryManager != null) repositoryManager.Dispose();
             }
         }

src/GitHub.Api/NewTaskSystem/ITaskManager.cs

@@ -1,9 +1,10 @@
-using System.Threading;
+using System;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace GitHub.Unity
 {
-    interface ITaskManager
+    interface ITaskManager : IDisposable
     {
         TaskScheduler ConcurrentScheduler { get; }
         TaskScheduler ExclusiveScheduler { get; }
@@ -15,7 +16,6 @@ interface ITaskManager
         T ScheduleConcurrent<T>(T task) where T : ITask;
         T ScheduleExclusive<T>(T task) where T : ITask;
         T ScheduleUI<T>(T task) where T : ITask;
-        void Stop();
         Task Wait();
     }
 }

src/GitHub.Api/NewTaskSystem/TaskManager.cs

@@ -8,7 +8,7 @@ class TaskManager : ITaskManager
     {
         private static readonly ILogging logger = Logging.GetLogger<TaskManager>();
 
-        private readonly CancellationTokenSource cts;
+        private CancellationTokenSource cts;
         private readonly ConcurrentExclusiveInterleave manager;
         public TaskScheduler UIScheduler { get; set; }
         public TaskScheduler ConcurrentScheduler { get { return manager.ConcurrentTaskScheduler; } }
@@ -31,12 +31,6 @@ public TaskManager(TaskScheduler uiScheduler)
             this.UIScheduler = uiScheduler;
         }
 
-        public void Stop()
-        {
-            cts.Cancel();
-            Wait();
-        }
-
         public Task Wait()
         {
             return manager.Wait();
@@ -56,7 +50,6 @@ public static TaskScheduler GetScheduler(TaskAffinity affinity)
             }
         }
 
-
         public void Schedule(params ITask[] tasks)
         {
             Guard.ArgumentNotNull(tasks, "tasks");
@@ -157,5 +150,30 @@ private T ScheduleConcurrent<T>(T task, bool setupFaultHandler)
             }
             return (T)task.Start(manager.ConcurrentTaskScheduler);
         }
+
+        private void Stop()
+        {
+            if (cts == null)
+                throw new ObjectDisposedException(nameof(TaskManager));
+            cts.Cancel();
+            Wait();
+            cts = null;
+        }
+
+        private bool disposed = false;
+        private void Dispose(bool disposing)
+        {
+            if (disposed) return;
+            disposed = true;
+            if (disposing)
+            {
+                Stop();
+            }
+        }
+
+        public void Dispose()
+        {
+            Dispose(true);
+        }
     }
 }

src/tests/IntegrationTests/BaseIntegrationTest.cs

@@ -40,7 +40,7 @@ public virtual void OnSetup()
         [TearDown]
         public virtual void OnTearDown()
         {
-            TaskManager.Instance?.Stop();
+            TaskManager.Instance?.Dispose();
             Logger.Debug("Deleting TestBasePath: {0}", TestBasePath.ToString());
             for (var i = 0; i < 5; i++)
             {

src/tests/TaskSystemIntegrationTests/Tests.cs

@@ -56,7 +56,7 @@ public void OneTimeSetup()
         [TestFixtureTearDown]
         public void OneTimeTearDown()
         {
-            TaskManager?.Stop();
+            TaskManager?.Dispose();
             try
             {
                 TestBasePath.DeleteIfExists();