Merge pull request #1001 from github-for-unity/pr/1000-fix-asmdef-files-giving-errors-on-2018-3

fix: asmdef files giving errors on 2018.3

Author: shana

src/UnityExtension/Assets/Editor/GitHub.Unity/ExtensionLoader/ExtensionLoader.asmdef

@@ -1,8 +1,15 @@
 {
     "name": "ExtensionLoader",
-    "references": ["../../build/GitHub.UnityShim.dll"],
+    "references": [],
+    "optionalUnityReferences": [],
     "includePlatforms": [
         "Editor"
     ],
-    "excludePlatforms": []
+    "excludePlatforms": [],
+    "allowUnsafeCode": false,
+    "overrideReferences": true,
+    "precompiledReferences": [
+        "GitHub.UnityShim.dll"
+    ],
+    "autoReferenced": true
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/Misc/Utility.cs

@@ -37,16 +37,14 @@ public static Texture2D GetIcon(string filename, string filename2x = "", bool in
             Texture2D texture2D = null;
 
             var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("GitHub.Unity.IconsAndLogos." + filename);
-            if (stream != null)
+            if (stream == null)
             {
-                texture2D = stream.ToTexture2D();
-            }
-            else
-            {
-                var iconPath = "Assets/Editor/GitHub.Unity/IconsAndLogos/" + filename;
-                texture2D = AssetDatabase.LoadAssetAtPath<Texture2D>(iconPath);
+                stream = new MemoryStream(Application.dataPath.ToNPath().Combine("Editor/GitHub.Unity/IconsAndLogos/", filename).ReadAllBytes());
             }
 
+            texture2D = stream.ToTexture2D();
+            stream.Dispose();
+
             if (texture2D != null)
             {
                 texture2D.hideFlags = HideFlags.HideAndDontSave;

src/UnityExtension/Assets/Editor/UnityTests/UnityTests.asmdef

@@ -3,8 +3,16 @@
     "references": [
         "GitHub.Unity"
     ],
+    "optionalUnityReferences": [
+        "TestAssemblies"
+    ],
     "includePlatforms": [
         "Editor"
     ],
-    "excludePlatforms": []
+    "excludePlatforms": [],
+    "allowUnsafeCode": false,
+    "overrideReferences": false,
+    "precompiledReferences": [],
+    "autoReferenced": true,
+    "defineConstraints": []
 }

src/UnityExtension/ProjectSettings/ProjectVersion.txt

@@ -0,0 +1 @@
+m_EditorVersion: 2018.3.2f1