Merge pull request #809 from github-for-unity/fixes/niceio-obey-deletemode

Obey the DeleteMode flag when deleting files too

Author: StanleyGoldman

src/GitHub.Api/IO/NiceIO.cs

@@ -688,20 +688,27 @@ public void Delete(DeleteMode deleteMode = DeleteMode.Normal)
             if (IsRoot)
                 throw new NotSupportedException("Delete is not supported on a root level directory because it would be dangerous:" + ToString());
 
-            if (FileExists())
-                FileSystem.FileDelete(ToString());
-            else if (DirectoryExists())
-                try
+            var isFile = FileExists();
+            var isDir = DirectoryExists();
+            if (!isFile && !isDir)
+                throw new InvalidOperationException("Trying to delete a path that does not exist: " + ToString());
+
+            try
+            {
+                if (isFile)
                 {
-                    FileSystem.DirectoryDelete(ToString(), true);
+                    FileSystem.FileDelete(ToString());
                 }
-                catch (IOException)
+                else
                 {
-                    if (deleteMode == DeleteMode.Normal)
-                        throw;
+                    FileSystem.DirectoryDelete(ToString(), true);
                 }
-            else
-                throw new InvalidOperationException("Trying to delete a path that does not exist: " + ToString());
+            }
+            catch (IOException)
+            {
+                if (deleteMode == DeleteMode.Normal)
+                    throw;
+            }
         }
 
         public void DeleteIfExists(DeleteMode deleteMode = DeleteMode.Normal)